Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry: fixup requirements #18034

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

Cogitri
Copy link
Contributor

@Cogitri Cogitri commented Jun 23, 2023

Some of these tool requirements are only needed with some options enabled

Specify library name and version: opentelemetry/*


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Jun 26, 2023
@AbrilRBS AbrilRBS closed this Jun 26, 2023
@AbrilRBS AbrilRBS reopened this Jun 26, 2023
@AbrilRBS
Copy link
Member

Retriggering CI builds after the last ones failed due to some issue in CI on the weekend

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Hi @Cogitri can you bump the boost dependency to 1.82 to resolve the conflict please? Thanks!

Cogitri added 2 commits June 27, 2023 13:36
Some of these tool requirements are only needed with some options enabled
@Cogitri Cogitri force-pushed the opentelemetry-v2 branch from 5bc5506 to 47bb3cc Compare June 27, 2023 11:37
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (47bb3cc307d1166d16059f5160d43ee47f22841b):

  • opentelemetry-cpp/1.8.1@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.9.1@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.6.1@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.7.0@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.4.0@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.0.1@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.3.0@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.2.0@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.4.1@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 4 (47bb3cc307d1166d16059f5160d43ee47f22841b):

  • opentelemetry-cpp/1.9.1@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.2.0@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.6.1@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.8.1@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.7.0@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.4.0@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.3.0@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.0.1@:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.4.1@:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@@ -440,6 +443,7 @@ def package_info(self):
self.options.with_elasticsearch
):
self.cpp_info.components[self._http_client_name].requires.append("libcurl::libcurl")
self.cpp_info.components[self._http_client_name].requires.append("openssl::openssl")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Cogitri! Thanks for the contribution.
Shouldn't this also be added to the opentelemetry_exporter_etw component?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czoido could you possibly explain it in more details why should it be added, from your point of view? what's the motivation, what's the benefit, etc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSE4 It's because the recipe logic, when you have with_etw=True it adds openssl as a requirement if I'm not mistaken.

@conan-center-bot conan-center-bot merged commit df8344a into conan-io:master Jun 29, 2023
tannerbitz pushed a commit to tannerbitz/conan-center-index that referenced this pull request Jul 8, 2023
* opentelemetry-cpp: fixup requirements

Some of these tool requirements are only needed with some options enabled

* opentelemetry-cpp: bump boost dependency
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* opentelemetry-cpp: fixup requirements

Some of these tool requirements are only needed with some options enabled

* opentelemetry-cpp: bump boost dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants