-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry: fixup requirements #18034
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Retriggering CI builds after the last ones failed due to some issue in CI on the weekend |
This comment has been minimized.
This comment has been minimized.
Hi @Cogitri can you bump the boost dependency to 1.82 to resolve the conflict please? Thanks! |
Some of these tool requirements are only needed with some options enabled
5bc5506
to
47bb3cc
Compare
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 4 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
@@ -440,6 +443,7 @@ def package_info(self): | |||
self.options.with_elasticsearch | |||
): | |||
self.cpp_info.components[self._http_client_name].requires.append("libcurl::libcurl") | |||
self.cpp_info.components[self._http_client_name].requires.append("openssl::openssl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Cogitri! Thanks for the contribution.
Shouldn't this also be added to the opentelemetry_exporter_etw
component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@czoido could you possibly explain it in more details why should it be added, from your point of view? what's the motivation, what's the benefit, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SSE4 It's because the recipe logic, when you have with_etw=True
it adds openssl as a requirement if I'm not mistaken.
* opentelemetry-cpp: fixup requirements Some of these tool requirements are only needed with some options enabled * opentelemetry-cpp: bump boost dependency
* opentelemetry-cpp: fixup requirements Some of these tool requirements are only needed with some options enabled * opentelemetry-cpp: bump boost dependency
Some of these tool requirements are only needed with some options enabled
Specify library name and version: opentelemetry/*