Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zookeeper-client-c: add recipe #17849

Merged

Conversation

toge
Copy link
Contributor

@toge toge commented Jun 6, 2023

Specify library name and version: zookeeper/3.8.1

Try to close #17787.

While zookkeeper-client-c requires code generated from jute, this recipe requires the installation of jdk and maven, which are needed to execute jute.


@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Hooks produced the following warnings for commit 1354f78
zookeeper-client-c/3.8.1
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './zookeeper-compatibility-tests/zookeeper-compatibility-tests-curator/src/test/java/org/apache/zookeeper/compatibility/TestApacheCuratorCompatibility.java' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/org/apache/zookeeper/inspector/encryption/BasicDataEncryptionManager.java' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/org/apache/zookeeper/inspector/gui/ZooInspectorConnectionPropertiesDialog.java' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/org/apache/zookeeper/inspector/gui/nodeviewer/NodeSelectionListener.java' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/org/apache/zookeeper/inspector/manager/ZooInspectorNodeTreeManager.java' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './zookeeper-contrib/zookeeper-contrib-zooinspector/src/test/java/org/apache/zookeeper/inspector/manager/ZooInspectorManagerImplTest.java' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/test/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProviderConfigTest.java' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @toge for your contribution. I'm requesting changes to discuss adding a maven recipe to cci to be used as a tool_requires

recipes/zookeeper-client-c/all/conanfile.py Outdated Show resolved Hide resolved
@toge toge marked this pull request as draft June 7, 2023 07:07
@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Jul 6, 2023
@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 6, 2023

Seems like it's not finding the mvn executable. Maybe there's a buildenv missing somewhere?

@toge
Copy link
Contributor Author

toge commented Jul 6, 2023

@RubenRBS
Sadly I know little about conan's buildenv functionality.
Do you know any good recipe examples?

@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 7, 2023

Sorry, I explained myself wrong, I meant VirtualBuildEnv :) I've now pushed the necessary changes not to have to bother you with it :)

@toge
Copy link
Contributor Author

toge commented Jul 7, 2023

@RubenRBS
Thank you very much.
I didn't realize that it worked without VirtualBuildEnv in my local environment.
I will use your code in future recipe creation.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (70156530b20f7d6cd577100e5ad0ea6b45a68db6):

  • zookeeper-client-c/3.8.1@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 6 (70156530b20f7d6cd577100e5ad0ea6b45a68db6):

  • zookeeper-client-c/3.8.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 1ca8454 into conan-io:master Jul 7, 2023
amrox pushed a commit to exyntech/conan-center-index that referenced this pull request Jul 12, 2023
* zookeeper-client-c: add recipe

* enable short_paths

* support msvc

* use maven recipe

* Add VirtualBuildEnv

---------

Co-authored-by: Rubén Rincón <rubenrb@jfrog.com>
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* zookeeper-client-c: add recipe

* enable short_paths

* support msvc

* use maven recipe

* Add VirtualBuildEnv

---------

Co-authored-by: Rubén Rincón <rubenrb@jfrog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] zookeeper-client-c/3.8.1
4 participants