Added libqasm recipe #17719

rturrado · 2023-05-26T15:30:47Z

Specify library name and version: libqasm/0.6.5

libqasm is a library for handling cQASM files using C++ or Python (https://github.com/QuTech-Delft/libqasm, https://libqasm.readthedocs.io/en/latest/).
It is used by OpenQL, a framework for high-level quantum programming in C++/Python (https://github.com/QuTech-Delft/OpenQL, https://openql.readthedocs.io/en/latest/).
Both libqasm and OpenQL are developed by QuTech-Delft (TU Delft), for which I work as a software engineer.
It is a new addition to ConanCenter.
I basically want OpenQL users to be able to use libqasm in a simple way (i.e. without needing to install libqasm's dependencies manually).

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've used conan 2.0.4.
I've tried at least one configuration locally with the conan-center hook activated.
I've tried building both in Linux and Windows in release and debug modes. These are the commands I use in each platform:
conan create all/conanfile.py --version 0.5.0
conan create all/conanfile.py --version 0.5.0 -o libqasm/*:build_type=Debug

…20_compilation_errors.patch, and updated conandata.yml as suggested in the pull request review.

…ow to use 'using' type aliases).

libqasm

This reverts commit a94d7b1.

This reverts commit 05fbdb8.

…e)." This reverts commit 788b028.

…sn't allow to use 'using' type aliases)." This reverts commit 73c9294.

…fix_cpp_20_compilation_errors.patch, and updated conandata.yml as suggested in the pull request review." This reverts commit 6e1cafe.

This reverts commit 22fc695.

CLAassistant · 2023-05-26T15:30:52Z

All committers have signed the CLA.

…o 3.20 (for cxx_std_23). conandata.yml: added '0.5.1' to sources. conanfile.py: - layout: 'src_folder' set to '.'. - source: get sources from conandata.yml. - validate: updated to be compliant with Conan 1.x.

* pixman/all/: bump deps * pixman/all: bump deps Generated and committed by [Conan Center Bump Deps](https://github.com/ericLemanissier/conan-center-index-bump-deps) Find more updatable recipes in the [GitHub Pages](https://ericlemanissier.github.io/conan-center-index-bump-deps/)

rturrado · 2024-05-02T21:05:28Z

@SpaceIm @SSE4 @RubenRBS @uilianries anyone please do a second code review? Thanks!

uilianries

Looking good, only small details.

recipes/libqasm/all/conanfile.py

rturrado · 2024-05-03T07:53:01Z

Looking good, only small details.

Many thanks @uilianries!

uilianries

LGTM

AbrilRBS

Hi! Thanks a lot, I have a few last minute change requests, but other than that it looks finally ready :)

I have also a request. The library seems aware of wasm. Have you locally tested it in such arch? If so, could you please provide compilation logs of the default build (So just conan create ...) and shared? (conan create ... -o="*:shared=True")? Thanks a lot! It helps tremendously with future maintenance and traceability

recipes/libqasm/all/conanfile.py

rturrado · 2024-05-05T11:36:05Z

Hi! Thanks a lot, I have a few last minute change requests, but other than that it looks finally ready :)

I have also a request. The library seems aware of wasm. Have you locally tested it in such arch? If so, could you please provide compilation logs of the default build (So just conan create ...) and shared? (conan create ... -o="*:shared=True")? Thanks a lot! It helps tremendously with future maintenance and traceability

Hi @RubenRBS. I am not sure if we have what you ask for because we only cross-compile for emscripten/WASM.

libqasm WASM binaries are already being tested/used in the future Quantum Inspire 2 website.

You can find the binaries for the latest libqasm release here.

Should you want to build them and run them:

$ curl -fsSL https://deno.land/install.sh | sh  # install deno
$ git clone https://github.com/QuTech-Delft/libqasm.git  # clone libqasm
$ cd libqasm
libqasm$ conan build . -pr=conan/profiles/emscripten -pr:b=conan/profiles/release -b missing  # cross-compile for emscripten
libqasm$ mv build/Release/emscripten/cqasm_emscripten.{,m}js  # rename js file to mjs (because it's an ES6 module)
libqasm$ cd emscripten
libqasm/emscripten$ deno run -A test_cqasm.ts  # test the WASM binaries

You also have GitHub logs for the conan build above here.

And, for the shared build, please find attached the logs: conan__build__pr_emscripten__pr_b_release__o_shared_True__b_missing.txt

I hope this helps!

rturrado · 2024-05-07T17:00:47Z

@RubenRBS sorry for the stalking haha but I'm just so much willing this to go forward. Thanks!

conan-center-bot · 2024-05-08T14:08:27Z

Conan v1 pipeline ✔️

All green in build 41 (91a912ddaa81179946652e64c340c249c6af46f3):

libqasm/0.6.5:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 41 (91a912ddaa81179946652e64c340c249c6af46f3):

libqasm/0.6.5:
All packages built successfully! (All logs)

AbrilRBS

Thanks a lot for taking the time to create the recipe, we really appreciate it :)

rturrado · 2024-05-09T17:15:55Z

Thanks a lot for taking the time to create the recipe, we really appreciate it :)

You won't believe me but I've been dreaming about this moment since more than one year ago. 😄

Long live the Conan team!

rturrado added 17 commits January 28, 2023 18:19

coin-lemon: fixed C++17 and C++20 compilation warnings.

22fc695

coin-lemon: renamed fix_cpp_20_compilation_warnings.patch to fix_cpp_…

6e1cafe

…20_compilation_errors.patch, and updated conandata.yml as suggested in the pull request review.

coin-lemon: updated patch to fix gcc 5 compilation (gcc 5 doesn't all…

73c9294

…ow to use 'using' type aliases).

coin-lemon: fix conandata.yml (by removing an extra blank line).

788b028

coin-lemon: fixed C++20 compilation errors for path.h too.

05fbdb8

coin-lemon: added patch_source lines to conandata.yml.

a94d7b1

Merge branch 'conan-io:master' into master

7fa1657

Adding a recipe for libqasm at Conan Center.

e21eaf3

Trying to fix some Linter errors.

c2bbd6d

Trying to fix a remaining Linter error.

a8f067e

Merge pull request #1 from rturrado/libqasm

1dae883

libqasm

Revert "coin-lemon: added patch_source lines to conandata.yml."

5da3903

This reverts commit a94d7b1.

Revert "coin-lemon: fixed C++20 compilation errors for path.h too."

dbd7486

This reverts commit 05fbdb8.

Revert "coin-lemon: fix conandata.yml (by removing an extra blank lin…

3ad0f76

…e)." This reverts commit 788b028.

Revert "coin-lemon: updated patch to fix gcc 5 compilation (gcc 5 doe…

dc8fe15

…sn't allow to use 'using' type aliases)." This reverts commit 73c9294.

Revert "coin-lemon: renamed fix_cpp_20_compilation_warnings.patch to …

f03dad4

…fix_cpp_20_compilation_errors.patch, and updated conandata.yml as suggested in the pull request review." This reverts commit 6e1cafe.

Revert "coin-lemon: fixed C++17 and C++20 compilation warnings."

0afe1ea

This reverts commit 22fc695.

conan-center-bot added the Failed label May 26, 2023

This comment has been minimized.

Sign in to view

rturrado added 4 commits May 26, 2023 17:50

Merge branch 'master' into libqasm

774056c

Fixed some review checks.

a26c779

Merge remote-tracking branch 'origin/libqasm' into libqasm

9302896

Merge branch 'master' into libqasm

a30bc16

This comment has been minimized.

Sign in to view

rturrado added 2 commits May 28, 2023 01:19

test_package/CMakeLists.txt: updated CMake minimum required version t…

2a29cd5

…o 3.20 (for cxx_std_23). conandata.yml: added '0.5.1' to sources. conanfile.py: - layout: 'src_folder' set to '.'. - source: get sources from conandata.yml. - validate: updated to be compliant with Conan 1.x.

Merge remote-tracking branch 'origin/libqasm' into libqasm

75a541f

This comment has been minimized.

Sign in to view

ericLemanissier added 2 commits May 28, 2023 01:45

(conan-io#17714) lzo: generate missing binaries

93c18e6

uilianries reviewed May 3, 2024

View reviewed changes

recipes/libqasm/all/conanfile.py Outdated Show resolved Hide resolved

recipes/libqasm/all/conanfile.py Show resolved Hide resolved

recipes/libqasm/all/conanfile.py Show resolved Hide resolved

rturrado added 2 commits May 3, 2024 09:52

Addressed some minor changes from uilianries code review.

9be9be0

Merge remote-tracking branch 'origin/libqasm' into libqasm

0529d2f

This comment has been minimized.

Sign in to view

rturrado added 2 commits May 3, 2024 11:00

Fix typo.

209d730

Remove unused rmdir.

62071fb

This comment has been minimized.

Sign in to view

rturrado requested review from uilianries and valgur May 3, 2024 10:13

uilianries previously approved these changes May 3, 2024

View reviewed changes

uilianries assigned AbrilRBS May 3, 2024

valgur approved these changes May 3, 2024

View reviewed changes

AbrilRBS reviewed May 4, 2024

View reviewed changes

recipes/libqasm/all/conanfile.py Outdated Show resolved Hide resolved

recipes/libqasm/all/conanfile.py Outdated Show resolved Hide resolved

Addressed some minor changes from RubenRBS code review.

91a912d

rturrado dismissed uilianries’s stale review via 91a912d May 5, 2024 11:11

This comment has been minimized.

Sign in to view

rturrado requested review from AbrilRBS, valgur and uilianries May 5, 2024 13:05

uilianries approved these changes May 6, 2024

View reviewed changes

AbrilRBS approved these changes May 9, 2024

View reviewed changes

conan-center-bot merged commit c49507b into conan-io:master May 9, 2024
13 checks passed

rturrado deleted the libqasm branch October 9, 2024 15:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added libqasm recipe #17719

Added libqasm recipe #17719

rturrado commented May 26, 2023 •

edited

Loading

CLAassistant commented May 26, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rturrado commented May 2, 2024

uilianries left a comment

rturrado commented May 3, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

AbrilRBS left a comment

rturrado commented May 5, 2024

This comment has been minimized.

rturrado commented May 7, 2024

conan-center-bot commented May 8, 2024

AbrilRBS left a comment

rturrado commented May 9, 2024

Added libqasm recipe #17719

Added libqasm recipe #17719

Conversation

rturrado commented May 26, 2023 • edited Loading

CLAassistant commented May 26, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rturrado commented May 2, 2024

uilianries left a comment

Choose a reason for hiding this comment

rturrado commented May 3, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

AbrilRBS left a comment

Choose a reason for hiding this comment

rturrado commented May 5, 2024

This comment has been minimized.

rturrado commented May 7, 2024

conan-center-bot commented May 8, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

AbrilRBS left a comment

Choose a reason for hiding this comment

rturrado commented May 9, 2024

rturrado commented May 26, 2023 •

edited

Loading

CLAassistant commented May 26, 2023 •

edited

Loading