Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wt: add transitive_headers = True for boost dependency #17615

Closed
wants to merge 5 commits into from
Closed

wt: add transitive_headers = True for boost dependency #17615

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15edf71
wt: add transitive_headers = True for boost dependency
pskoko May 18, 2023
52ce427
Merge branch 'master' into master
AbrilRBS May 18, 2023
4261109
Merge branch 'master' into master
AbrilRBS May 19, 2023
95ec452
Add openssl requirement range
AbrilRBS May 19, 2023
e483cd9
Merge pull request #1 from RubenRBS/pskoko-master
pskoko May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions recipes/wt/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,15 @@ def _required_boost_components(self):

def requirements(self):
if Version(self.version) < "4.6.0":
self.requires("boost/1.76.0")
self.requires("boost/1.76.0", transitive_headers = True)
elif Version(self.version) < "4.9.0":
self.requires("boost/1.80.0")
self.requires("boost/1.80.0", transitive_headers = True)
else:
self.requires("boost/1.81.0")
self.requires("boost/1.81.0", transitive_headers = True)
if self.options.connector_http:
self.requires("zlib/1.2.13")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need transitive_libs or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS I am not sure for zlib, but errors in failed apple build point out that maybe transitive_libs=True should be added for openssl. On Apple build openssl version range is resolved to 3.1.0 which, unlike 1.1.1t, has zlib as its dependency (unless no_zlib=True is set up), and error messages show that all missing symbols are from libcrypto.a which is from openssl.

Also, by experimenting with using wt as shared library on Linux, I concluded that libunwind also needs transitive libs = True. Without that, linking an executable which uses wt as shared library fails, it prints that some symbols from xz (which is dependency of libunwind) are undefined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows I managed to get the errors equivalent to the apple build from CI (by setting openssl dependency explictitly to 3.1.0 version, it would always resolve to 1.1.1t): missing zlib from libcrypto.lib (for example: libcrypto.lib(libcrypto-lib-c_zlib.obj) : error LNK2019: unresolved external symbol deflate referenced in function zlib_stateful_compress_block). Adding transitive_libs = True on openssl didn't resolve it.

if self.options.with_ssl:
self.requires("openssl/1.1.1t")
self.requires("openssl/[>=1.1 <4]")
if self.options.get_safe("with_sqlite"):
self.requires("sqlite3/3.41.1")
if self.options.get_safe("with_mysql"):
Expand Down