Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paho-mqtt-c: remove anl library from system libs #17442

Closed
wants to merge 4 commits into from

Conversation

mtudan
Copy link

@mtudan mtudan commented May 7, 2023

Remove anl library from default system libraries if on Linux because it is not available on non-glibc distros like Alpine. This will fix building your apps on e.g. Alpine that link with paho-mqtt-c library. We might use some logic to determine if anl is available like the upstream project does.

Specify library name and version: paho-mqtt-c/1.3.12


@CLAassistant
Copy link

CLAassistant commented May 7, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Remove anl library from default system libraries if on Linux because it is
not available on non-glibc distros like Alpine.
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 25, 2023

@SpaceIm You added anl in https://github.com/conan-io/conan-center-index/pull/17088/files#diff-cefdb38dd5cec800413f548cb236f4f8cb7fd28165ef036164d59b456553cbd4R121 do you happen to recall why?

Because it was reported by hooks: #17088 (comment)

See also https://github.com/eclipse/paho.mqtt.c/blob/7db21329301b1f527c925dff789442db3ca3c1e7/src/CMakeLists.txt#L67-L70, but yes it's optional. There is not enough granularity in conan profiles to predict if anl is required as a system libs or not.

@prince-chrismc
Copy link
Contributor

Cheers! Thanks for helping :)

@mtudan
Copy link
Author

mtudan commented Sep 14, 2023

@prince-chrismc @franramirez688 @jcar87

Any news with this PR? That's quite old right now.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (457516520969e86f6260316087a7e08313fe239d):

  • paho-mqtt-c/1.3.12:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.11:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.10:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.5:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.9:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.8:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.4:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.6:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (457516520969e86f6260316087a7e08313fe239d):

  • paho-mqtt-c/1.3.12:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.11:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.9:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.4:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.5:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.10:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.8:
    All packages built successfully! (All logs)

  • paho-mqtt-c/1.3.6:
    All packages built successfully! (All logs)

@uilianries
Copy link
Member

It's possible to customize the settings, adding distro: https://docs.conan.io/2/reference/config_files/settings.html#adding-new-settings

It could be used for this case, having a condition to not add anl in case distro Alpine, for instance.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 22, 2024
Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants