Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yajl: initial onboarding (v2.1.0) #17285

Merged
merged 3 commits into from
May 5, 2023
Merged

yajl: initial onboarding (v2.1.0) #17285

merged 3 commits into from
May 5, 2023

Conversation

gegles
Copy link
Contributor

@gegles gegles commented Apr 27, 2023 •
edited
Loading

Specify library name and version: yajl/2.1.0

This PR aims at adding the YAJL library to the Conan Center.

Overall, it was a very straightforward process and I essentially was able to follow the template project.

The looks hooks all reported OK.

@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Apr 27, 2023
Open
@gegles gegles force-pushed the yajl branch 2 times, most recently from 2ed1cbd to 9772fe3 Compare April 27, 2023 17:18
@conan-center-bot

This comment has been minimized.

Sign in to view
1 similar comment
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Apr 27, 2023
Merged
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit bb725c5
yajl/2.1.0 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libyajl.2.dylib, libyajl.dylib, libyajl.2.1.0.dylib

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 680704a
yajl/2.1.0 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libyajl.2.dylib, libyajl.dylib, libyajl.2.1.0.dylib

@gegles
Copy link
Contributor Author

gegles commented Apr 29, 2023

FYI @bemehiser

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 3198fb7
yajl/2.1.0 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libyajl.2.dylib, libyajl.dylib, libyajl.2.1.0.dylib

@gegles gegles force-pushed the yajl branch 2 times, most recently from f50eb5f to e7d0c25 Compare May 1, 2023 15:41
@conan-center-bot

This comment has been minimized.

Sign in to view
@gegles
Copy link
Contributor Author

gegles commented May 2, 2023

@prince-chrismc @RubenRBS et. al. just FYI, this one is all green and ready to go ;-) Thx!

@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handful of comment to cleanup some of the extras :) the template are very over zealous nd you need way less is most cases

@prince-chrismc
Copy link
Contributor

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

@conan-center-bot

This comment has been minimized.

Sign in to view
@gegles
Copy link
Contributor Author

gegles commented May 2, 2023

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

Oops, so sorry, my bad. I kept my commit addressing your comments separate, but indeed I did rebase/force-push to be on the latest master... I won't do that going forward. thx!

@prince-chrismc
Copy link
Contributor

The bot does a squash merge so everything will be one big commit in the end so it does not really matter :)
The bot also builds on master if it needs to you do not need to be on latest normally

@conan-center-bot

This comment has been minimized.

Sign in to view
@gegles gegles closed this May 2, 2023
@gegles gegles reopened this May 2, 2023
@prince-chrismc prince-chrismc reopened this May 3, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (86fc5b198a478f9ed3d8de4d6882a70731855400):

  • yajl/2.1.0@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 13 (86fc5b198a478f9ed3d8de4d6882a70731855400):

  • yajl/2.1.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 3781b88 into conan-io:master May 5, 2023
@gegles gegles deleted the yajl branch May 5, 2023 19:35
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
@gegles @pezy
(conan-io#17285) yajl: initial onboarding (v2.1.0)
3bd9944 
* yajl: initial onboarding (v2.1.0)

* yajl: address PR comments

* yajl: address PR comments (cont.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gegles @conan-center-bot @prince-chrismc @jwillikers