-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCIP mixed-integer programming solver #17242
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
HI @prince-chrismc, this is a follow-up to #16017. I need help here. I do not know why the pipeline fails. I cannot see the reason. |
It had already passed, I am not sure why you triggered it again? |
Known bug, race condition when it merges PRs sometimes build fail
|
This is a big PR so I suspect it will take time for someone to review it. you'll need some extra patience on this one :) |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
… are aligned Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@hedtke Please, consider https://github.com/hedtke/conan-center-index/pull/2. That PR has several fixes for this PR. Regards. |
This comment has been minimized.
This comment has been minimized.
Prepare SCIP recipe for CCI PR
This comment has been minimized.
This comment has been minimized.
@uilianries Thank you very much for your help! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I would like to publish other software that depends on this. Please have a look into it. I think everything is fine. Failed pipelines are due to a technical issue on the server side, I think. |
@hedtke I just started a new CI build internal. Let's hope it does not fail again. |
recipes/scip/all/conanfile.py
Outdated
tc.variables["SHARED"] = self.options.shared | ||
tc.variables["READLINE"] = False # required for interactive stuff | ||
tc.variables["GMP"] = self.options.with_gmp | ||
tc.variables["BOOST"] = self.options.with_boost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find BOOST variable in 8.0.3, how do you activate/deactivate it?
% grep BOOST -r
./INSTALL.md:| `BOOST_ROOT` | `<custom/path/to/.../boost>` | -- | hint for location of boost |
./src/cppad/core/testvector.hpp:$code CPPAD_BOOSTVECTOR$$ will be true.
./src/cppad/core/testvector.hpp:# if CPPAD_BOOSTVECTOR
./src/cppad/core/test_vector.hpp:of $code CPPAD_BOOSTVECTOR$$:
./src/cppad/core/test_vector.hpp:# if CPPAD_BOOSTVECTOR
./src/cppad/core/test_vector.hpp:# undef CPPAD_BOOSTVECTOR
./src/cppad/core/test_vector.hpp:# define CPPAD_BOOSTVECTOR 0
./src/cppad/core/test_vector.hpp:$code CPPAD_BOOSTVECTOR$$ is true
./src/cppad/core/test_vector.hpp:# if CPPAD_BOOSTVECTOR
./src/cppad/core/undef.hpp:# undef CPPAD_BOOSTVECTOR
./src/cppad/configure.hpp:\def CPPAD_BOOSTVECTOR
./src/cppad/configure.hpp:# define CPPAD_BOOSTVECTOR 0
It's clear that Soplex needs boost, but it seems like libscip does not use it. Could you show where boost is used and activated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, just an include path depends on this setting, not the package itself. I dropped the option.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 22 (
Conan v2 pipeline ✔️
All green in build 17 (
|
* Add SCIP mixed-integer solver * Do not export bliss in shared mode * Add option with_sym * Bliss does not support libc++ * Use normpath on Windows * Replace backslash in Windows paths * Bliss is built in another directory under Windows * Add package_type * Add zlib as dependency Co-authored-by: Uilian Ries <uilianries@gmail.com> * Check that the options between this package and its dependency soplex are aligned Co-authored-by: Uilian Ries <uilianries@gmail.com> * Remove v1 test package * Always depend on boost and gmp, independently of the parameters * improve scip recipe Signed-off-by: Uilian Ries <uilianries@gmail.com> * use bliss 0.77 Signed-off-by: Uilian Ries <uilianries@gmail.com> * Drop option with_boost --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
Specify library name and version: scip/8.0.3
I am not the author of this lib, but we use it at my company. This PR resolves #14180