Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCIP mixed-integer programming solver #17242

Merged
merged 16 commits into from
Jul 14, 2023
Merged

Add SCIP mixed-integer programming solver #17242

merged 16 commits into from
Jul 14, 2023

Conversation

hedtke
Copy link
Contributor

@hedtke hedtke commented Apr 26, 2023

Specify library name and version: scip/8.0.3

I am not the author of this lib, but we use it at my company. This PR resolves #14180


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@hedtke
Copy link
Contributor Author

hedtke commented May 9, 2023

HI @prince-chrismc, this is a follow-up to #16017. I need help here. I do not know why the pipeline fails. I cannot see the reason.

@prince-chrismc
Copy link
Contributor

It had already passed, I am not sure why you triggered it again?

@prince-chrismc
Copy link
Contributor

Known bug, race condition when it merges PRs sometimes build fail

hudson.remoting.ProxyException: Assertion failed: 

assert parentCommits[1] == masterCommit

	at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:404)

@prince-chrismc
Copy link
Contributor

prince-chrismc commented May 9, 2023

This is a big PR so I suspect it will take time for someone to review it. you'll need some extra patience on this one :)

@conan-center-bot

This comment has been minimized.

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

hedtke and others added 3 commits June 6, 2023 10:17
Co-authored-by: Uilian Ries <uilianries@gmail.com>
… are aligned

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

hedtke and others added 3 commits June 6, 2023 11:21
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

@hedtke Please, consider https://github.com/hedtke/conan-center-index/pull/2. That PR has several fixes for this PR. Regards.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@hedtke
Copy link
Contributor Author

hedtke commented Jun 6, 2023

Please, consider hedtke#2. That PR has several fixes for this PR. Regards.

@uilianries Thank you very much for your help!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@hedtke
Copy link
Contributor Author

hedtke commented Jul 5, 2023

I would like to publish other software that depends on this. Please have a look into it. I think everything is fine. Failed pipelines are due to a technical issue on the server side, I think.

@uilianries
Copy link
Member

@hedtke I just started a new CI build internal. Let's hope it does not fail again.

@uilianries uilianries self-assigned this Jul 5, 2023
tc.variables["SHARED"] = self.options.shared
tc.variables["READLINE"] = False # required for interactive stuff
tc.variables["GMP"] = self.options.with_gmp
tc.variables["BOOST"] = self.options.with_boost
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find BOOST variable in 8.0.3, how do you activate/deactivate it?

 % grep BOOST -r 
./INSTALL.md:| `BOOST_ROOT`           | `<custom/path/to/.../boost>`       | --                         | hint for location of boost                                         |
./src/cppad/core/testvector.hpp:$code CPPAD_BOOSTVECTOR$$ will be true.
./src/cppad/core/testvector.hpp:# if CPPAD_BOOSTVECTOR
./src/cppad/core/test_vector.hpp:of $code CPPAD_BOOSTVECTOR$$:
./src/cppad/core/test_vector.hpp:# if CPPAD_BOOSTVECTOR
./src/cppad/core/test_vector.hpp:# undef  CPPAD_BOOSTVECTOR
./src/cppad/core/test_vector.hpp:# define CPPAD_BOOSTVECTOR 0
./src/cppad/core/test_vector.hpp:$code CPPAD_BOOSTVECTOR$$ is true
./src/cppad/core/test_vector.hpp:# if CPPAD_BOOSTVECTOR
./src/cppad/core/undef.hpp:# undef CPPAD_BOOSTVECTOR
./src/cppad/configure.hpp:\def CPPAD_BOOSTVECTOR
./src/cppad/configure.hpp:# define CPPAD_BOOSTVECTOR 0

It's clear that Soplex needs boost, but it seems like libscip does not use it. Could you show where boost is used and activated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, just an include path depends on this setting, not the package itself. I dropped the option.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 22 (7a0b70961a495172044e3e96aee1f75d1e039254):

  • scip/8.0.3@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 17 (7a0b70961a495172044e3e96aee1f75d1e039254):

  • scip/8.0.3@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit b70a905 into conan-io:master Jul 14, 2023
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* Add SCIP mixed-integer solver

* Do not export bliss in shared mode

* Add option with_sym

* Bliss does not support libc++

* Use normpath on Windows

* Replace backslash in Windows paths

* Bliss is built in another directory under Windows

* Add package_type

* Add zlib as dependency

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Check that the options between this package and its dependency soplex are aligned

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Remove v1 test package

* Always depend on boost and gmp, independently of the parameters

* improve scip recipe

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* use bliss 0.77

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Drop option with_boost

---------

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] scip/8.0.3
6 participants