Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlsec: fix url of tarballs + bump dependencies #17062

Merged
merged 10 commits into from
Apr 28, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 17, 2023


@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 18, 2023

----Running------
> "C:\J\w\prod\BuildSingleReference\.conan\data\xmlsec\1.2.30\_\_\build\264debb1906857b32718bd142de59e6edd6de2c7\build-debug\conan\conanbuild.bat" && cscript configure.js prefix=C:\J\w\prod\BuildSingleReference\.conan\data\xmlsec\1.2.30\_\_\package\264debb1906857b32718bd142de59e6edd6de2c7 cruntime=/MDd debug=yes static=no include="C:\J\w\prod\BuildSingleReference\.conan\data\libxml2\2.10.4\_\_\package\cca1f4d21d53907bc47c9118217088c8378bb6d3\include;C:\J\w\prod\BuildSingleReference\.conan\data\libxml2\2.10.4\_\_\package\cca1f4d21d53907bc47c9118217088c8378bb6d3\include\libxml2;C:\J\w\prod\BuildSingleReference\.conan\data\openssl\3.1.0\_\_\package\93e13514e79f4e5c082cf3505874df8af370579c\include;C:\J\w\prod\BuildSingleReference\.conan\data\zlib\1.2.13\_\_\package\d057732059ea44a47760900cb5e4855d2bea8714\include;C:\J\w\prod\BuildSingleReference\.conan\data\libiconv\1.17\_\_\package\d057732059ea44a47760900cb5e4855d2bea8714\include" lib="C:\J\w\prod\BuildSingleReference\.conan\data\libxml2\2.10.4\_\_\package\cca1f4d21d53907bc47c9118217088c8378bb6d3\lib;C:\J\w\prod\BuildSingleReference\.conan\data\openssl\3.1.0\_\_\package\93e13514e79f4e5c082cf3505874df8af370579c\lib;C:\J\w\prod\BuildSingleReference\.conan\data\zlib\1.2.13\_\_\package\d057732059ea44a47760900cb5e4855d2bea8714\lib;C:\J\w\prod\BuildSingleReference\.conan\data\libiconv\1.17\_\_\package\d057732059ea44a47760900cb5e4855d2bea8714\lib" with-dl=no xslt=no iconv=no crypto=openssl=310
-----------------
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.11.25
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Microsoft (R) Windows Script Host Version 5.812
Copyright (C) Microsoft Corporation. All rights reserved.

Unknown crypto engine "openssl=310" is found. Aborting.

This configure.js for msvc is not future proof. In autotools branch, openssl 3.x works fine.

Some parts of lsh123/xmlsec#342 & lsh123/xmlsec#396 should be backported I guess.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 18, 2023

It's weird. I've pushed another commit, but it doesn't show up 🤔

@SpaceIm SpaceIm force-pushed the xmlsec-fix-url-bump-openssl branch from 7fe7f43 to d8de837 Compare April 18, 2023 14:44
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Apr 19, 2023
@SpaceIm SpaceIm reopened this Apr 19, 2023
@conan-center-bot

This comment has been minimized.

@weinhold
Copy link

weinhold commented Apr 20, 2023

Any chance of adding the latest version?

  "1.2.37":
    url: "http://www.aleksey.com/xmlsec/download/xmlsec1-1.2.37.tar.gz"
    sha256: "5f8dfbcb6d1e56bddd0b5ec2e00a3d0ca5342a9f57c24dffde5c796b2be2871c"

@conan-center-bot

This comment has been minimized.

jwillikers
jwillikers previously approved these changes Apr 20, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (a50d9efc1cdad4ede7209dac6b3fd701ee6cf6a9):

  • xmlsec/1.2.30@:
    All packages built successfully! (All logs)

  • xmlsec/1.2.31@:
    All packages built successfully! (All logs)

  • xmlsec/1.2.32@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 10 (a50d9efc1cdad4ede7209dac6b3fd701ee6cf6a9):

  • xmlsec/1.2.31@:
    All packages built successfully! (All logs)

  • xmlsec/1.2.32@:
    All packages built successfully! (All logs)

  • xmlsec/1.2.30@:
    All packages built successfully! (All logs)

test_type = "explicit"

def layout(self):
cmake_layout(self)

def requirements(self):
self.requires(self.tested_reference_str)
self.requires("libxml2/2.10.4")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT would have been nice to have dc5da99 here since it's out of the norm

@conan-center-bot conan-center-bot merged commit b7896c3 into conan-io:master Apr 28, 2023
@SpaceIm SpaceIm deleted the xmlsec-fix-url-bump-openssl branch April 28, 2023 23:26
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
* fix url of tarballs

* bump dependencies

* libxml2 public headers are exposed in xmlsec public headers

* add libxml2 to requires of test package for conan v2 since it's directly used in test source code

* link to libxml2 and eventually libxslt in test package

* openssl headers are also public

* typo

* add libxml2 to requires of test package since CMakeDeps seems to be affected by traits

* use https

* use version range for openssl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants