Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drogon: add version 1.8.4, update dependencies #16872

Merged
merged 16 commits into from
Jul 3, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Apr 3, 2023

Specify library name and version: drogon/*

  • add version 1.8.4
  • update dependencies

@conan-center-bot

This comment has been minimized.

@toge toge closed this Apr 4, 2023
@toge toge reopened this Apr 4, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge toge closed this May 10, 2023
@toge toge reopened this May 10, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge toge closed this May 23, 2023
@toge toge reopened this May 23, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@franramirez688
Copy link
Contributor

franramirez688 commented Jun 26, 2023

Hi @toge

I don't really know if drogon/1.80 should require cppstd=17 at least for Windows. The CI is failing due to this:

profiles

======== Input profiles ========
Profile host:
[settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.runtime_type=Release
compiler.version=192
os=Windows
[options]
*/*:shared=False
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True

Profile build:
[settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.runtime_type=Release
compiler.version=192
os=Windows
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True

output (simplified)

-- Conan toolchain: C++ Standard 14 with extensions OFF
-- Conan toolchain: Setting BUILD_SHARED_LIBS = OFF
-- The C compiler identification is MSVC 19.29.30148.0
-- The CXX compiler identification is MSVC 19.29.30148.0
......
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED - Success
-- Found std::filesystem
-- use c++14
........
-- Boost include dir: C:/J/w/prod-v2/BuildSingleReference/p/boostee2540e656934/p/include
-- Using Boost filesytem::path
-- Boost include dir: C:/J/w/prod-v2/BuildSingleReference/p/boostee2540e656934/p/include
-- Boost libraries: boost::boost
-- Conan: Target declared 'JsonCpp::JsonCpp'
-- Conan: Including build module from 'C:/J/w/prod-v2/BuildSingleReference/p/opensc15130f38a7f7/p/lib/cmake/conan-official-openssl-variables.cmake'
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Configuring done
-- Generating done
-- Build files have been written to: C:/J/w/prod-v2/BuildSingleReference/p/b/drogo3cf50649e2846/b/build

drogon/1.8.0: Running CMake.build()
drogon/1.8.0: RUN: cmake --build "C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\build" --config Release
Microsoft (R) Build Engine version 16.11.2+f32259642 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Checking Build System
  Building Custom Rule C:/J/w/prod-v2/BuildSingleReference/p/b/drogo3cf50649e2846/b/src/CMakeLists.txt
  AOPAdvice.cc
  CacheFile.cc
  ConfigLoader.cc
  Cookie.cc
  DrClassMap.cc
  DrTemplateBase.cc
  FiltersFunction.cc
  HttpAppFrameworkImpl.cc
  The contents of <string_view> are available only with C++17 or later.
  The contents of <optional> are available only with C++17 or later.
C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\inc\drogon/utils/optional.h(25,12): error C2039: 'nullopt': is not a member of 'std' (compiling source file C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\src\Cookie.cc) [C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\build\drogon.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\yvals.h(344): message : see declaration of 'std' (compiling source file C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\src\Cookie.cc) [C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\build\drogon.vcxproj]
C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\inc\drogon/utils/optional.h(25,1): error C2873: 'nullopt': symbol cannot be used in a using-declaration (compiling source file C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\src\Cookie.cc) [C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\build\drogon.vcxproj]
C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\inc\drogon/utils/optional.h(26,12): error C2039: 'optional': is not a member of 'std' (compiling source file C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\src\Cookie.cc) [C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\build\drogon.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\yvals.h(344): message : see declaration of 'std' (compiling source file C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\src\Cookie.cc) [C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\build\drogon.vcxproj]
C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\inc\drogon/utils/optional.h(26,1): error C2873: 'optional': symbol cannot be used in a using-declaration (compiling source file C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\src\lib\src\Cookie.cc) [C:\J\w\prod-v2\BuildSingleReference\p\b\drogo3cf50649e2846\b\build\drogon.vcxproj]
  The contents of <string_view> are available only with C++17 or later.

Should it be an extra check to ensure Windows the minimum cppstd is C++17? any ideas?

UPDATED:
I just realized Conan 1.x is passing without any issues so I have to figure out what's happening there.

@toge
Copy link
Contributor Author

toge commented Jun 26, 2023

@franramirez688
Thank you for your information.
I created additional patches for MSVC C++14 build.
They will fix several invalid msvc version checks.

I hope CI will be successful.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.


#pragma once
-#if __cplusplus >= 201703L || (defined _MSC_VER && _MSC_VER > 1900)
+#if __cplusplus >= 201703L
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, Visual C++ defines the __cplusplus macro to be 199711L by default, unless a flag is passed to the compiler (docs: https://learn.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-170)
Hence the || checks, checking against the value of _MSC_VER - I can se how this can be misleading: modern Visual C++ defaults to C++ 14, but these are features of C++17 that seem available even when in C++14 (default) mode, correct?

So this may be causing the "boost" implementation to be used unconditionally with Visual C++, even when in C++17 or C++20 modes - is this expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcar87
Thanks!
I try it.

@toge toge closed this Jun 30, 2023
@toge toge reopened this Jun 30, 2023
@AbrilRBS
Copy link
Member

Jenkins seems to be acting up today, relaunching

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 30 (55f7de0e965a8d2f423649ec9ea8521355adf854):

  • drogon/1.8.3@:
    All packages built successfully! (All logs)

  • drogon/1.8.2@:
    All packages built successfully! (All logs)

  • drogon/1.8.0@:
    All packages built successfully! (All logs)

  • drogon/1.7.5@:
    All packages built successfully! (All logs)

  • drogon/1.8.4@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 26 (55f7de0e965a8d2f423649ec9ea8521355adf854):

  • drogon/1.8.4@:
    All packages built successfully! (All logs)

  • drogon/1.7.5@:
    All packages built successfully! (All logs)

  • drogon/1.8.0@:
    All packages built successfully! (All logs)

  • drogon/1.8.3@:
    All packages built successfully! (All logs)

  • drogon/1.8.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit bd635eb into conan-io:master Jul 3, 2023
tannerbitz pushed a commit to tannerbitz/conan-center-index that referenced this pull request Jul 8, 2023
* drogon: add version 1.8.4, update dependencies

* update openssl

* update openssl, sqlite3

* make trantor transitive_libs

* Added jsoncpp transitive_libs=True param

* Added package_type and with_yaml_cpp option (optional requirement)

* support C++14 build on msvc

* make boost transitive_headers=True

* add /Zc:__cplusplus on MSVC

* add /EHsc flag for msvc

---------

Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* drogon: add version 1.8.4, update dependencies

* update openssl

* update openssl, sqlite3

* make trantor transitive_libs

* Added jsoncpp transitive_libs=True param

* Added package_type and with_yaml_cpp option (optional requirement)

* support C++14 build on msvc

* make boost transitive_headers=True

* add /Zc:__cplusplus on MSVC

* add /EHsc flag for msvc

---------

Co-authored-by: Francisco Ramirez de Anton <franchuti688@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants