Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libedit/3.1 recipe #1680

Merged
merged 5 commits into from
May 27, 2020
Merged

Add libedit/3.1 recipe #1680

merged 5 commits into from
May 27, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented May 19, 2020

Specify library name and version: libedit/3.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libedit/3.1' failed in build 1 (19d884cf8b62504bd6555a25bc35ea6814acc72a):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libedit/3.1' failed in build 2 (35da7150a8c5f59d1f7bbaf688418419db01b455):

@conan-center-bot
Copy link
Collaborator

All green in build 3 (58ecc5453ca4ddb410e154e1b842c40d58544414)! 😊

uilianries
uilianries requested changes May 22, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, only small details

recipes/libedit/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libedit/all/conanfile.py Outdated Show resolved Hide resolved
@madebr @uilianries
libtedit: add TODO for missing recipe
d6fc22d 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 4 (d6fc22daf9b5e0518a1b174e7605fc6af37eb095)! 😊

uilianries
uilianries previously approved these changes May 22, 2020
View reviewed changes
@uilianries uilianries requested review from SSE4 and danimtb May 22, 2020 15:34
SSE4
SSE4 previously approved these changes May 23, 2020
View reviewed changes
@uilianries uilianries requested a review from jgsogo May 25, 2020 12:09
jgsogo
jgsogo reviewed May 25, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we name this one editline and reserve libedit to the original one?

http://thrysoee.dk/editline/

This is an autotool- and libtoolized port of the NetBSD Editline library (libedit). This Berkeley-style licensed command line editor library provides generic line editing, history, and tokenization functions, similar to those found in GNU Readline.

@madebr
Copy link
Contributor Author

madebr commented May 25, 2020

Shall we name this one editline and reserve libedit to the original one?

http://thrysoee.dk/editline/

This is an autotool- and libtoolized port of the NetBSD Editline library (libedit). This Berkeley-style licensed command line editor library provides generic line editing, history, and tokenization functions, similar to those found in GNU Readline.

Good point.
I'll make the change.

@madebr madebr dismissed stale reviews from SSE4 and uilianries via 15baa81 May 25, 2020 23:56
@madebr
Copy link
Contributor Author

madebr commented May 25, 2020

@SSE4 @uilianries @jgsogo
Please re-review!

@conan-center-bot
Copy link
Collaborator

All green in build 5 (15baa813d4fe5c5e30f2d1fc174dcfc85f0d1dc6)! 😊

@jgsogo jgsogo requested a review from SSE4 May 27, 2020 11:53
@SSE4 SSE4 merged commit 85c701c into conan-io:master May 27, 2020
@madebr madebr deleted the libedit_recipe branch May 27, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@jgsogo jgsogo jgsogo approved these changes

@SSE4 SSE4 SSE4 approved these changes

@danimtb danimtb Awaiting requested review from danimtb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madebr @conan-center-bot @SSE4 @jgsogo @uilianries