Add mysql connector cpp lib #16429

ahmed192a · 2023-03-07T19:31:29Z

Specify library name and version: mysql-connector-cpp/8.0.27

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2023-03-07T19:31:44Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

conan-center-bot · 2023-03-12T06:42:04Z

Conan v1 pipeline ❌

Failure in build 11 (d9152a3a33ab395789f8020590b45a06e84a934d):

mysql-connector-cpp/8.0.27@:
Error running command conan export recipes/mysql-connector-cpp/all/conanfile.py mysql-connector-cpp/8.0.27@:

[HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
[HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
[HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
[HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 3.107421875 KB
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: CMakeLists.txt
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
[HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
[HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
[HOOK - conan-center.py] pre_export(): ERROR: [RECIPE METADATA (KB-H003)] Conanfile doesn't have 'homepage' attribute.  (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H003-RECIPE-METADATA) 
[HOOK - conan-center.py] pre_export(): WARN: [FPIC OPTION (KB-H006)] This recipe does not include an 'fPIC' option. Make sure you are using the right casing
[HOOK - conan-center.py] pre_export(): ERROR: [CONAN CENTER INDEX URL (KB-H027)] The attribute 'url' should point to: https://github.com/conan-io/conan-center-index (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H027-CONAN-CENTER-INDEX-URL) 
[HOOK - conan-center.py] pre_export(): ERROR: [CONANDATA.YML FORMAT (KB-H030)] Exception raised from hook: string indices must be integers (type=TypeError) (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H030-CONANDATA.YML-FORMAT) 
ERROR: [HOOK - conan-center.py] pre_export(): string indices must be integers

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 11 (d9152a3a33ab395789f8020590b45a06e84a934d):

mysql-connector-cpp/8.0.27@:
CI failed to create some packages (All logs)

Logs for packageID 18ff221a2c98c6b3f32b0c4723988757f9ef4507:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

[...]
Requirements
    mysql-connector-cpp/8.0.27#8d384eee866c5fc72bc966796c7f2c42:18ff221a2c98c6b3f32b0c4723988757f9ef4507 - Build
    openssl/1.1.0l#401ce70f553c8ed60586a3b2967dfac3:aaa3cbf3729901a9315aba1078813f2c82c9de5d#b5888f86ebacd49c3fe51f4b4f736513 - Download (conan-center)

======== Installing packages ========

-------- Downloading 1 package --------
openssl/1.1.0l: Retrieving package aaa3cbf3729901a9315aba1078813f2c82c9de5d from remote 'conan-center' 
Downloading conan_package.tgz
Decompressing conan_package.tgz
openssl/1.1.0l: Package installed aaa3cbf3729901a9315aba1078813f2c82c9de5d
openssl/1.1.0l: Downloaded package revision b5888f86ebacd49c3fe51f4b4f736513
WARN: The use of 'cpp_info.names' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
WARN: The use of 'cpp_info.names' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
WARN: The use of 'cpp_info.build_modules' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
WARN: The use of 'cpp_info.build_modules' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
WARN: The use of 'cpp_info.names' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
WARN: The use of 'cpp_info.names' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
WARN: The use of 'cpp_info.names' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
WARN: The use of 'cpp_info.names' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
mysql-connector-cpp/8.0.27: Calling source() in mysql-connector-cpp
mysql-connector-cpp/8.0.27: RUN: git clone https://github.com/mysql/mysql-connector-cpp.git
Cloning into 'mysql-connector-cpp'...

mysql-connector-cpp/8.0.27: RUN: cd mysql-connector-cpp && git checkout 8.0.27
Note: switching to '8.0.27'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at e84f6a55 Bug#33352469 UT


-------- Building package mysql-connector-cpp/8.0.27 from source (2 of 2) --------
mysql-connector-cpp/8.0.27: Package mysql-connector-cpp/8.0.27:18ff221a2c98c6b3f32b0c4723988757f9ef4507
mysql-connector-cpp/8.0.27: Copying sources to build folder
ERROR: [Errno 2] No such file or directory: '/home/conan/w/prod-v2/BuildSingleReference/p/mysql974d59674bfea/s'
Error copying sources to build folder

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

stale · 2023-04-11T07:48:43Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jcar87

Hi @ahmed192a - thank you so much for your contribution! It's a good one :)

I've added some review comments, however I would greatly encourage you to review the template we have for CMake libraries and draw from there: https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package

Please let us know if you need further assistance!

jcar87 · 2023-05-10T14:19:22Z

recipes/mysql-connector-cpp/all/conandata.yml

@@ -0,0 +1,3 @@
+sources:
+  "8.0.27":
+    "https://github.com/mysql/mysql-connector-cpp/archive/refs/tags/8.0.27.tar.gz"


please add a sha256 with the expected checksum at the time of contributing

jcar87 · 2023-05-10T14:19:53Z

recipes/mysql-connector-cpp/all/conanfile.py

+
+class MysqlConnectorCppConan(ConanFile):
+    name = "mysql-connector-cpp"
+    version = "8.0.27"


the version attribute is not needed as the CI service will build the versions listed in config.yml

jcar87 · 2023-05-10T14:20:28Z

recipes/mysql-connector-cpp/all/conanfile.py

+    version = "8.0.27"
+    license = "GPLv2"
+    author = "Oracle"
+    url = "https://dev.mysql.com/doc/connector-cpp/en/"


for url in we use the URL of this repository (conan-center-index in GitHub), while the homepage attribute points to that of the library itself

jcar87 · 2023-05-10T14:20:56Z

recipes/mysql-connector-cpp/all/conanfile.py

+    description = "MySQL Connector/C++ is a MySQL database connector for C++."
+    topics = ("mysql", "database", "connector", "c++")
+    settings = "os", "compiler", "build_type", "arch"
+    options = {"shared": [True, False]}


the options for libraries in Conan Center should also include fPIC, as per:
https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/cmake_package/all/conanfile.py#L32-L39

jcar87 · 2023-05-10T14:21:30Z

recipes/mysql-connector-cpp/all/conanfile.py

+    options = {"shared": [True, False]}
+    default_options = {"shared": False}
+    generators = "CMakeToolchain"
+    exports_sources = "CMakeLists.txt"


I can't see this file being part of the pull request - if the library already ahs its CMakeLists.txt chances are this is not needed at all

jcar87 · 2023-05-10T14:22:01Z

recipes/mysql-connector-cpp/all/conanfile.py

+    generators = "CMakeToolchain"
+    exports_sources = "CMakeLists.txt"
+    requires = "openssl/1.1.0l"
+    source_folder = "mysql-connector-cpp"


source_folder and build_folder are not needed, but please use a cmake_layout as per
https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/cmake_package/all/conanfile.py#L70-L72

jcar87 · 2023-05-10T14:22:23Z

recipes/mysql-connector-cpp/all/conanfile.py

+    source_folder = "mysql-connector-cpp"
+    build_folder = "build"
+
+    def config_options(self):


if a method is not needed, please remove it - although I suspect it will be needed once there is an fpic option:

https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/cmake_package/all/conanfile.py#L59-L61

jcar87 · 2023-05-10T14:22:59Z

recipes/mysql-connector-cpp/all/conanfile.py

+
+
+    def source(self):
+        self.run("git clone https://github.com/mysql/mysql-connector-cpp.git")


please follow the pattern from https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/cmake_package/all/conanfile.py#L97-L98
so that the sources are retrieved from the tar.gz in conandata.yml

ghost · 2023-05-17T05:12:01Z

I detected other pull requests that are modifying mysql-connector-cpp/all recipe:

mysql-connector-cpp:8.3.0 #17594

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

stale · 2023-06-18T02:15:22Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jcar87 · 2023-06-27T08:53:48Z

Hi @ahmed192a - we are still waiting for your feedback on the review comments in order to proceed with this PR - gentle remidner!

stale · 2023-08-07T03:27:42Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2023-10-15T12:08:01Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

ahmed192a added 4 commits March 7, 2023 21:21

Create config.yml

e94fc91

Create conandata.yml

ef5d209

Create conanfile.py

c81f1a3

Add files via upload

530bcf0

conan-center-bot added the Failed label Mar 7, 2023