Revise modular boost policy and clarify options which do no impact package_id
#15494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
SSE4
reviewed
Jan 27, 2023
SSE4
reviewed
Jan 27, 2023
|
/cc @grafikrobot as it's about boost libraries maybe, it's worth to add some links to the official documents on how to add library into boost? |
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> Co-authored-by: SSE4 <tomskside@gmail.com>
|
Thanks for the excellent reviews, you're the best |
grafikrobot
approved these changes
Jan 27, 2023
1 task
SSE4
approved these changes
Jan 29, 2023
AbrilRBS
approved these changes
Jan 29, 2023
| @@ -420,12 +420,20 @@ Please, read [Inactivity and user removal section](adding_packages/README.md#ina | |||
|
|
|||
| ## Can we add package which are parts of bigger projects like Boost? | |||
|
|
|||
| Sadly no. There have been many efforts in the past and we feel it's not sustainable given the number of combinations of libraries and version. See #14660 for recent discussions. | |||
| Sadly no. There have been many efforts in the past and we feel it's not sustainable given the number of combinations of libraries and version. | |||
There was a problem hiding this comment.
Suggested change
| Sadly no. There have been many efforts in the past and we feel it's not sustainable given the number of combinations of libraries and version. | |
| Sadly no. There have been many efforts in the past and we feel it's not sustainable given the number of combinations of libraries and versions. |
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
…h do no impact `package_id` * Update conanfile_attributes.md * no small boost + maybe define options * Apply suggestions from code review Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> Co-authored-by: SSE4 <tomskside@gmail.com> --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> Co-authored-by: SSE4 <tomskside@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs!
closes #14625