Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix drogon sqlite target #15233

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

okaerin
Copy link
Contributor

@okaerin okaerin commented Jan 12, 2023

  • added a patch to allow sqlite enabling

Specify library name and version: drogon/1.8.*

This patch adresses the issue #15217 . With the applied patch it is possible to build drogon with sqlite enabled, as the target is found by conan and not the drogon supplied cmake files.


- added a patch to allow sqlite enabling
@CLAassistant
Copy link

CLAassistant commented Jan 12, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Jan 12, 2023

I detected other pull requests that are modifying drogon/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

- patch version 1.8.0
- patch version 1.8.2
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (fc8876b42851ebe83ac7edf710462d65d03b680b):

  • drogon/1.8.2@:
    All packages built successfully! (All logs)

  • drogon/1.8.0@:
    All packages built successfully! (All logs)

  • drogon/1.7.5@:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sorry about the delay to get this merged caused by the holidays :)

@conan-center-bot conan-center-bot merged commit cc2b475 into conan-io:master Jan 27, 2023
@okaerin okaerin deleted the fix/drogon_sqlite_target branch January 27, 2023 15:14
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* fix drogon sqlite target

- added a patch to allow sqlite enabling

* add newline to patch

* fix patch line number

* different patches

- patch version 1.8.0
- patch version 1.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants