-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
m4: add package_type attribute #15183
m4: add package_type attribute #15183
Conversation
I detected other pull requests that are modifying m4/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
I'm wondering: what should be the package_type if a recipe is both an application and a library? |
the package_types influence which traits are enabled by default on the consumers side, without consumers having to do so explicitly, but I believe for more special cases consumers do have the freedom of specifying the traits more explicitly to match how something is used |
Conan v1 pipelineAll green in build 1 (
Conan v2 pipeline (informative, not required for merge)Failure in build 1 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Seems like this is a subset of the linked PR which also seems to add v2 support (Although its v2 pipeline is failing just as this one is) and Chris wants to talk about it at the next shepherds meeting |
The v2 image is so out of date I just ask contributors to ignore that 🙃 The PRs are completely theoretical at this time. |
As for the other PR, Recipes doing things we can not test and what should be allowed has never been resolved so it would be great to have a list of DOs and DONTs to help Give reviewers a base line. Or at least set a process for the team to decide on them. Then write the list as we go Being from source should also be a client feature with a conf setting ;) so we can accept that in the future |
Specify library name and version: m4/all
In Conan 2, this is required for downstream consumers to be exposed to PATH/m4 variables from this recipe, when
m4
is a transitive dependency (i.e., not direct).