Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m4: add package_type attribute #15183

Merged

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Jan 9, 2023

Specify library name and version: m4/all

In Conan 2, this is required for downstream consumers to be exposed to PATH/m4 variables from this recipe, when m4 is a transitive dependency (i.e., not direct).

@ghost
Copy link

ghost commented Jan 9, 2023

I detected other pull requests that are modifying m4/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Jan 9, 2023
4 tasks
@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 9, 2023

I'm wondering: what should be the package_type if a recipe is both an application and a library?

@jcar87
Copy link
Contributor Author

jcar87 commented Jan 9, 2023

I'm wondering: what should be the package_type if a recipe is both an application and a library?

the package_types influence which traits are enabled by default on the consumers side, without consumers having to do so explicitly, but I believe for more special cases consumers do have the freedom of specifying the traits more explicitly to match how something is used

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 1 (0c51d549bc078c57e37b1a3b382833d21652b29f):

  • m4/1.4.19@:
    All packages built successfully! (All logs)

  • m4/1.4.18@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge)

Failure in build 1 (0c51d549bc078c57e37b1a3b382833d21652b29f):

  • m4/1.4.19@:
    Didn't run or was cancelled before finishing

  • m4/1.4.18@:
    CI failed to create some packages (All logs)

    Logs for packageID 3593751651824fb813502c69c971267624ced41a:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    
    [...]
    make[4]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/lib'
    make[3]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/lib'
    make[2]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/lib'
    Making install in src
    make[2]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/src'
    make[3]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/src'
    make[3]: Nothing to be done for 'install-data-am'.
     /bin/mkdir -p '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/p//bin'
      /usr/bin/install -c m4 '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/p//bin'
    make[3]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/src'
    make[2]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/src'
    Making install in doc
    make[2]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/doc'
    make[3]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/doc'
    make[3]: Nothing to be done for 'install-exec-am'.
     /bin/mkdir -p '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/p//share/man/man1'
     /bin/mkdir -p '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/p//share/info'
     /usr/bin/install -c -m 644 /home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/src/doc/m4.1 '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/p//share/man/man1'
     /usr/bin/install -c -m 644 /home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/src/doc/m4.info /home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/src/doc/m4.info-1 /home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/src/doc/m4.info-2 '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/p//share/info'
    make[3]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/doc'
    make[2]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/doc'
    Making install in checks
    make[2]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/checks'
    make[3]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/checks'
    make[3]: Nothing to be done for 'install-exec-am'.
    make[3]: Nothing to be done for 'install-data-am'.
    make[3]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/checks'
    make[2]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/checks'
    Making install in tests
    make[2]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/tests'
    make  install-recursive
    make[3]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/tests'
    Making install in .
    make[4]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/tests'
    make[5]: Entering directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/tests'
    make[5]: Nothing to be done for 'install-exec-am'.
    make[5]: Nothing to be done for 'install-data-am'.
    make[5]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/tests'
    make[4]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/tests'
    make[3]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/tests'
    make[2]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release/tests'
    make[1]: Leaving directory '/home/conan/w/prod-v2/BuildSingleReference/p/tmp/5ea3f69958865ada/b/build-release'
    m4/1.4.18 package(): Packaged 2 files: m4, COPYING
    m4/1.4.18: Package '3593751651824fb813502c69c971267624ced41a' created
    m4/1.4.18: Created package revision 15e8bb13589a9ffdba20d82624d74052
    m4/1.4.18: Full package reference: m4/1.4.18#93c28dbeab2f68c5d9b66cd1d59cce95:3593751651824fb813502c69c971267624ced41a#15e8bb13589a9ffdba20d82624d74052
    m4/1.4.18: Package folder /home/conan/w/prod-v2/BuildSingleReference/p/68f43ad1d7645b8e/p
    m4/1.4.18: Appending PATH environment variable: /home/conan/w/prod-v2/BuildSingleReference/p/68f43ad1d7645b8e/p/bin
    WARN: The use of 'env_info' is deprecated in Conan 2.0 and will be removed in Conan 2.X. Please, update your recipes unless you are maintaining compatibility with Conan 1.X
    ERROR: m4/1.4.18: 'NoneType' object has no attribute 'append'. No default values are set for components. You are probably trying to manipulate a component attribute in the 'package_info' method without defining it previously
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@AbrilRBS
Copy link
Member

AbrilRBS commented Jan 9, 2023

Seems like this is a subset of the linked PR which also seems to add v2 support (Although its v2 pipeline is failing just as this one is) and Chris wants to talk about it at the next shepherds meeting

@prince-chrismc
Copy link
Contributor

The v2 image is so out of date I just ask contributors to ignore that 🙃

The PRs are completely theoretical at this time.

@prince-chrismc
Copy link
Contributor

As for the other PR, Recipes doing things we can not test and what should be allowed has never been resolved so it would be great to have a list of DOs and DONTs to help Give reviewers a base line.

Or at least set a process for the team to decide on them. Then write the list as we go

Being from source should also be a client feature with a conf setting ;) so we can accept that in the future

@conan-center-bot conan-center-bot merged commit e80254f into conan-io:master Jan 9, 2023
AbrilRBS pushed a commit to AbrilRBS/conan-center-index that referenced this pull request Jan 16, 2023
@jcar87 jcar87 deleted the hotfix/m4-add-package-type branch January 27, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants