Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow: remove patch for CMake #14903

Merged
merged 3 commits into from
Jan 5, 2023
Merged

arrow: remove patch for CMake #14903

merged 3 commits into from
Jan 5, 2023

Conversation

kou
Copy link
Contributor

@kou kou commented Dec 23, 2022

Specify library name and version: arrow/10.0.0

CMake find modules provided by Apache Arrow C++ 10.0.0 or later can work with Conan recipes. So we don't need to apply a CMake related patch to Apache Arrow C++ 10.0.0 or later and remove CMake find modules provided by Apache Arrow C++ 10.0.0 or later.

If we don't need to maintain a patch, we can add support for newer versions easily.

@kou
arrow: remove patch for CMake
1220dd0 
CMake find modules provided by Apache Arrow C++ 10.0.0 or later can
work with Conan recipes. So we don't need to apply a CMake related
patch to Apache Arrow C++ 10.0.0 or later and remove CMake find
modules provided by Apache Arrow C++ 10.0.0 or later.

If we don't need to maintain a patch, we can add support for newer
versions easily.
@ghost ghost mentioned this pull request Dec 23, 2022
Closed
@ghost
Copy link

ghost commented Dec 23, 2022

I detected other pull requests that are modifying arrow/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Dec 23, 2022
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@kou
Copy link
Contributor Author

kou commented Dec 23, 2022

Could someone help me?
The error message in #14903 (comment) said xsimd/9.0.1 isn't found but it seems that xsimd/9.0.1: https://conan.io/center/xsimd?version=9.0.1

What should we do to fix this error?

-------- Computing dependency graph --------
xsimd/9.0.1: Not found in local cache, looking in remotes...
xsimd/9.0.1: Checking remote: conan-center-v2
xsimd/9.0.1: Checking remote: c3i_PR-v2-14903
Graph root
    virtual
Requirements
    arrow/8.0.0#cb9c94fff00284fcd2fc2c459e4c29dd - Cache
Graph error
    Package 'xsimd/9.0.1' not resolved: Unable to find 'xsimd/9.0.1' in remotes

@kou kou marked this pull request as ready for review December 27, 2022 01:48
@prince-chrismc
Copy link
Contributor

It's a bug with the bot incorrectly adding the failed label, this checks all passed 🙈

The v2 pipeline is missing almost all the recipes/binaries so thats completely normal

@kou
Copy link
Contributor Author

kou commented Dec 27, 2022

Thanks!

Then, this is ready to review!

@kou @prince-chrismc
Add note for ARROW_PACAKGE_KIND=conan
7df1a32 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Dec 29, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 6 (7df1a3273d2cfa9b2d1e736343b49fc2a54f4db3):

  • arrow/8.0.1@:
    All packages built successfully! (All logs)

  • arrow/7.0.0@:
    All packages built successfully! (All logs)

  • arrow/10.0.0@:
    All packages built successfully! (All logs)

  • arrow/2.0.0@:
    All packages built successfully! (All logs)

  • arrow/8.0.0@:
    All packages built successfully! (All logs)

  • arrow/1.0.0@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge)

Failure in build 3 (7df1a3273d2cfa9b2d1e736343b49fc2a54f4db3):

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot conan-center-bot merged commit 2db76e1 into conan-io:master Jan 5, 2023
@kou kou deleted the arrow-not-remove-find-modules branch January 6, 2023 05:03
AbrilRBS pushed a commit to AbrilRBS/conan-center-index that referenced this pull request Jan 16, 2023
@kou @prince-chrismc @AbrilRBS
(conan-io#14903) arrow: remove patch for CMake
a2830e6 
* arrow: remove patch for CMake

CMake find modules provided by Apache Arrow C++ 10.0.0 or later can
work with Conan recipes. So we don't need to apply a CMake related
patch to Apache Arrow C++ 10.0.0 or later and remove CMake find
modules provided by Apache Arrow C++ 10.0.0 or later.

If we don't need to maintain a patch, we can add support for newer
versions easily.

* Don't use backport patch_type

* Add note for ARROW_PACAKGE_KIND=conan

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@Jean1995 Jean1995 mentioned this pull request Jan 19, 2023
Closed
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Mar 6, 2023
@datalogics-kam
Merge branch 'develop' of octocat.dlogics.com:datalogics/conan-center…
f9ea007 
…-index

* 'develop' of octocat.dlogics.com:datalogics/conan-center-index: (259 commits)
  Allow empty keys in dlproject.yaml for merging tasks
  (conan-io#15093) [libjpeg] Update sha256 for 9e
  (conan-io#15123) faac: add Visual Studio support + drop 1.28
  (conan-io#14103) gmp: conan v2 support
  (conan-io#14982) rapidyaml: add version 0.5.0
  (conan-io#15122) m4: use positional arguments when calling self.run()
  (conan-io#15091) catch2.x.x: Fix test_package for v2
  (conan-io#12938) capnproto: conan v2 support
  (conan-io#15097) http_parser: modernize
  (conan-io#15096) perlinnoise: add recipe
  (conan-io#15088) Make openexr v2 compatible
  (conan-io#15056) qt5: Apple OSs don't require CROSS_COMPILE option
  (conan-io#14974) libxshmfence: generate gcc11 binaries
  (conan-io#14903) arrow: remove patch for CMake
  (conan-io#14874) faac: conan v2 support
  (conan-io#13896) [gcc] Migrate recipe to conan v2, add gfortran to compilation
  Revert "(conan-io#14221) [config] Use larger resources to build cppfront packages" (conan-io#14953)
  (conan-io#15086) openh264: fix tools legacy
  (conan-io#15085) Make xkeyboard-config v2 compatible
  (conan-io#15089) Raise required_conan_version for xorg/system
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@danimtb danimtb danimtb approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
Unexpected Error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kou @conan-center-bot @prince-chrismc @uilianries @danimtb