Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyloggingpp: add options #14332

Merged

Conversation

geirhei
Copy link
Contributor

@geirhei geirhei commented Nov 21, 2022

Specify library name and version: easyloggingpp/9.97.0

Exposes more configuration options to conan.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@geirhei geirhei force-pushed the update-easyloggingpp-9.97.0 branch from 6541f02 to a43b054 Compare November 21, 2022 10:16
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@geirhei geirhei requested a review from uilianries November 21, 2022 13:16
@geirhei geirhei mentioned this pull request Nov 21, 2022
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@geirhei geirhei force-pushed the update-easyloggingpp-9.97.0 branch from 33f2afb to 102c2ec Compare November 28, 2022 19:56
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 6 (102c2ec212fb28fb0d60d0b0516cdf9e993a6956):

  • easyloggingpp/9.97.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-14332/recipes/easyloggingpp/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-14332/recipes/easyloggingpp/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-14332/recipes/easyloggingpp/all/conanfile.py", line 2, in <module>
        from conans import CMake
    ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@prince-chrismc
Copy link
Contributor

you should really contribute this CMake build script to upstream.

https://github.com/amrayn/easyloggingpp/blob/8489989bb26c6371df103f6cbced3fbee1bc3c2f/CMakeLists.txt#L61 does not even support these options and they are compiled in the .cc 🤷

Like this is required because of how CCI is shipping the lib but it does not match upstream which is really confusing

@conan-center-bot conan-center-bot merged commit 111318d into conan-io:master Dec 1, 2022
@geirhei geirhei deleted the update-easyloggingpp-9.97.0 branch December 2, 2022 08:35
@geirhei
Copy link
Contributor Author

geirhei commented Dec 4, 2022

you should really contribute this CMake build script to upstream.

https://github.com/amrayn/easyloggingpp/blob/8489989bb26c6371df103f6cbced3fbee1bc3c2f/CMakeLists.txt#L61 does not even support these options and they are compiled in the .cc shrug

Like this is required because of how CCI is shipping the lib but it does not match upstream which is really confusing

@prince-chrismc Made as issue for that upstream: abumq/easyloggingpp#826

Unfortunately, the project does not seem to be maintained anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants