-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
easyloggingpp: add options #14332
easyloggingpp: add options #14332
Conversation
This comment has been minimized.
This comment has been minimized.
6541f02
to
a43b054
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
33f2afb
to
102c2ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conan v1 pipelineAll green in build 6 (
|
you should really contribute this CMake build script to upstream. https://github.com/amrayn/easyloggingpp/blob/8489989bb26c6371df103f6cbced3fbee1bc3c2f/CMakeLists.txt#L61 does not even support these options and they are compiled in the .cc 🤷 Like this is required because of how CCI is shipping the lib but it does not match upstream which is really confusing |
@prince-chrismc Made as issue for that upstream: abumq/easyloggingpp#826 Unfortunately, the project does not seem to be maintained anymore. |
Specify library name and version: easyloggingpp/9.97.0
Exposes more configuration options to conan.