geotrans: conan v2 support #14317
Merged
geotrans: conan v2 support #14317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dddf37a to
cb3d7c8
Compare
cb3d7c8 to
b1f9084
Compare
Conan v1 pipelineAll green in build 3 (
|
| @@ -1,8 +1,7 @@ | |||
| sources: | |||
| "3.8": | |||
| url: "https://c3i.jfrog.io/artifactory/cci-sources-backup/sources/geotrans/geotrans-3.8.tgz" | |||
| sha256: "BAA72D3B1AE12F237A8AD30F2DEB3FED2B80FEB759528EA0A72B4B42CB77C565" | |||
| sha256: "baa72d3b1ae12f237a8ad30f2deb3fed2b80feb759528ea0a72b4b42cb77c565" | |||
There was a problem hiding this comment.
Please don't change the casing... I applied the wrong label
| cmake.build() | ||
|
|
||
| @contextmanager | ||
| def _workaround_2profiles(self): |
There was a problem hiding this comment.
🤔 what is this workarounding?
There was a problem hiding this comment.
env_info of requirements are not injected in self.run(..., run_environment=True) when using 2 profiles (only env_info of build_requirements I think).
prince-chrismc
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!