New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvault/0.51.0 #14234

Merged

conan-center-bot merged 8 commits into conan-io:master from goodtune:libvault/0.51.0

Nov 30, 2022

Contributor

goodtune commented Nov 17, 2022 •

edited

Loading

Specify library name and version: libvault/0.51.0

This is just an update to an existing package to provide the latest version on CCI.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant commented Nov 17, 2022 •

edited

Loading

All committers have signed the CLA.

conan-center-bot added the User-approval pending label

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This was referenced Nov 17, 2022

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

This comment has been minimized.

Sign in to view

goodtune added 2 commits

November 19, 2022 14:07


          libvault/0.51.0

044efaa


          Update recipe to satisfy YAML linter for conandata.yml

281c913

goodtune force-pushed the libvault/0.51.0 branch from f91dde9 to 281c913 Compare

November 19, 2022 03:07

conan-center-bot added Failed and removed User-approval pending labels

This comment has been minimized.

Sign in to view


          Update recipe to satisfy conanfile.py v2 linter

c074eea

goodtune force-pushed the libvault/0.51.0 branch from e4354ed to c074eea Compare

November 19, 2022 12:20

This comment has been minimized.

Sign in to view

Contributor Author

goodtune commented Nov 19, 2022

The failure in CI system is unexpected, I've tested it on MacOS and Linux without issues. Unfortunately it's opaque as I can't gain access to the build output to see what has failed.


          Reduce required_conan_version

b2833d2

Because there is a CI failure saying that the current version is `1.53.0`, despite `1.54.0` being available, I've knocked this value down.

goodtune mentioned this pull request

Release 0.52 abedra/libvault#109

Closed

This comment has been minimized.

Sign in to view


          Update to fix LICENSE file packaging

dfc6e92

This comment has been minimized.

Sign in to view

goodtune added 2 commits

November 24, 2022 23:31


          replace test_package and test_v1_package from templates

3344d8f


          Add special case for gcc8 and stdc++fs linking

b5f316d

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view

Contributor

github-actions bot commented Nov 24, 2022

Hooks produced the following warnings for commit b5f316d

libvault/0.48.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvault.so' links to system library 'm' but it is not in cpp_info.system_libs.

libvault/0.51.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvault.so' links to system library 'm' but it is not in cpp_info.system_libs.

Contributor Author

goodtune commented Nov 24, 2022

@uilianries and @SSE4, I was wondering if you would mind providing a review, please - you both approved the original inclusion back in #9117.

I've spent a fair bit of time tidying this up to meet all the current standards.

goodtune commented

View reviewed changes

recipes/libvault/all/conanfile.py

-                      self.cpp_info.libs = tools.collect_libs(self)
+                      self.cpp_info.libs = collect_libs(self)
+                      if self.settings.compiler == "gcc" and Version(self.settings.compiler.version).major == "8":
+                          self.cpp_info.system_libs.append("stdc++fs")

Contributor Author

goodtune Nov 24, 2022

I have to say, this workaround to make the test package compile for GCC 8 was a bit of a stumper for a while; I'm not sure if there is any detection that can be done around this in the report back to the recipe developer from the CI system.

For reference, it would manifest as:

.../lib/libvault.so: undefined reference to `std::filesystem::__cxx11::path::_M_split_cmpts()'
collect2: error: ld returned 1 exit status

Contributor Author

goodtune commented Nov 24, 2022

@sonicxml FYI, I'm updating your original recipe if you'd like to review this update.

uilianries reviewed

View reviewed changes

Member

uilianries left a comment

@goodtune Thank you for your contribution. Please, take a look on the review.

recipes/libvault/all/conanfile.py Outdated Show resolved Hide resolved

recipes/libvault/all/conanfile.py Outdated Show resolved Hide resolved

recipes/libvault/all/conanfile.py Outdated Show resolved Hide resolved

recipes/libvault/all/conanfile.py Show resolved Hide resolved

recipes/libvault/all/conanfile.py Outdated Show resolved Hide resolved

recipes/libvault/all/conanfile.py Outdated Show resolved Hide resolved

Contributor Author

goodtune commented Nov 25, 2022

Thanks @uilianries I will make those recommended updates and push later today.

conan-center-bot added the Failed label

This comment has been minimized.

Sign in to view


          Code review recommendations

ad1906b

goodtune force-pushed the libvault/0.51.0 branch from 1a1ffc1 to ad1906b Compare

November 27, 2022 01:20

conan-center-bot removed the Failed label

This comment has been minimized.

Sign in to view

Contributor

github-actions bot commented Nov 27, 2022

Hooks produced the following warnings for commit ad1906b

libvault/0.48.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvault.so' links to system library 'm' but it is not in cpp_info.system_libs.

libvault/0.51.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvault.so' links to system library 'm' but it is not in cpp_info.system_libs.

goodtune requested a review from uilianries

November 27, 2022 07:33

prince-chrismc approved these changes

View reviewed changes

uilianries approved these changes

View reviewed changes

Member

uilianries left a comment

LGTM

This comment has been minimized.

Sign in to view

prince-chrismc closed this

prince-chrismc reopened this

Collaborator

conan-center-bot commented Nov 30, 2022

Conan v1 pipeline

All green in build 12 (ad1906bce5d4c7c481ffdb334a93a22485949281):

libvault/0.51.0@:
All packages built successfully! (All logs)
libvault/0.48.0@:
All packages built successfully! (All logs)

conan-center-bot merged commit abc8968 into conan-io:master

goodtune deleted the libvault/0.51.0 branch

November 30, 2022 05:53

goodtune mentioned this pull request

libvault/0.52.0 #14498

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet