-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QArchive: Add version 2.2.2 and modernize #14212
QArchive: Add version 2.2.2 and modernize #14212
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
The dev kindly created a new tag with antony-jr/QArchive#62 so I don't have to include that as a patch here |
This comment has been minimized.
This comment has been minimized.
@ericriff v2.2.3 adds a commit for using c++17 standard when Qt6 is used, like how quazip does. Qt6 requires c++17 but we use c++11 by default in versions older than 2.2.3, so if you use v2.2.3 for conan, the package can be used with Qt6 also. Also you might want to set
|
I updated the recipe to use the new tagged version and I'm passing |
This comment has been minimized.
This comment has been minimized.
In QArchive build, If the cmake variable is not set then cmake uses the default version of Qt found by find package, the variable is only needed to be set if both qt5 and qt6 is installed, to select between the two, but by default its qt5. |
What's wrong with the consumer overriding the qt dep to what ever version they want? I mean |
I was thinking about having to edit the actual conanfile, but you're right, you can override it without editing the recipe. Please disregard my comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small change to keep aligned with the migration guide.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Is this stuck? 🤔 |
Conan v1 pipelineAll green in build 12 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for the latest version and modernize recipe and test packages.