Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cppcheck] Add version 2.9.1 #14149

Merged
merged 68 commits into from
Nov 28, 2022
Merged

[cppcheck] Add version 2.9.1 #14149

merged 68 commits into from
Nov 28, 2022

Conversation

Sneder89
Copy link
Contributor

@Sneder89 Sneder89 commented Nov 10, 2022 •
edited
Loading

Specify library name and version: cppcheck/2.9.1 cppcheck/2.8.2

I would like to add new versions of that useful tool and make the recipe ready for conan v2

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Nov 10, 2022
Closed
@ghost
Copy link

ghost commented Nov 10, 2022 •
edited by ghost
Loading

I detected other pull requests that are modifying cppcheck/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Open
This was referenced Nov 11, 2022
Open
Closed
MartinDelille
MartinDelille suggested changes Nov 11, 2022
View reviewed changes
recipes/cppcheck/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cppcheck/all/conandata.yml Outdated Show resolved Hide resolved
recipes/cppcheck/all/conandata.yml Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
Sneder89 and others added 2 commits November 14, 2022 07:53
@Sneder89
Update conandata.yml
f67f5a9
@Sneder89 @MartinDelille
Update recipes/cppcheck/all/conanfile.py
05a1f72 
Co-authored-by: Martin Delille <martin@delille.org>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
MartinDelille
MartinDelille previously approved these changes Nov 25, 2022
View reviewed changes
@MartinDelille
Copy link
Contributor

Nice job @Sneder89 ! 🎉

prince-chrismc
prince-chrismc reviewed Nov 25, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handful of small comments plus I got confused about the option that changes 🙈 if you can please enlighten me that be appreciated

recipes/cppcheck/all/conandata.yml
"2.9.2":
- patch_file: "patches/0001-cli-remove-dmake-cmake.patch"
- patch_file: "patches/0002-htmlreport-python3.patch"
- patch_file: "patches/0003-pcre-debuglib-name.patch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch fields 🙏 https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patches-fields

recipes/cppcheck/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cppcheck/all/conanfile.py Outdated
del self.options.with_z3

def package_id(self):
del self.info.options.with_z3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be required 🤔 we want it to change 2.8.0 and once it's deleted in config options than it's not taken into account

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I removed that from the package_id method

recipes/cppcheck/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cppcheck/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cppcheck/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cppcheck/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cppcheck/all/patches/0003-pcre-debuglib-name-2.7.patch

if (USE_Z3)
find_package(Z3 QUIET)
- if (NOT Z3_FOUND)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait I am confused --- When is this option added? this is a new patch but I thought the option was removed 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I made some changes to the patch. z3 is still required for 2.7.5, but removed for 2.8 and above. So if 2.10 is released, somebody can remove all these things.

recipes/cppcheck/all/test_package/conanfile.py Outdated
test_type = "explicit"

def requirements(self):
self.requires(self.tested_reference_str)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a tool rquires?

conan-center-index/docs/package_templates/prebuilt_tool_package/all/test_package/conanfile.py

Line 12 in b2dc1a2

self.tool_requires(self.tested_reference_str)

Sneder89 and others added 5 commits November 27, 2022 19:38
@Sneder89 @prince-chrismc
Update recipes/cppcheck/all/conanfile.py
7a3131c 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@Sneder89 @prince-chrismc
Update recipes/cppcheck/all/conanfile.py
e71f6d0 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@Sneder89 @prince-chrismc
Update recipes/cppcheck/all/conanfile.py
bfabc97 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@Sneder89 @prince-chrismc
Update recipes/cppcheck/all/conanfile.py
bd67112 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@Sneder89 @prince-chrismc
Update recipes/cppcheck/all/conanfile.py
01fa00a 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 62 (3247619b0877e45a2f9afee08514bba9a0331be7):

  • cppcheck/2.9.2@:
    All packages built successfully! (All logs)

  • cppcheck/2.8.2@:
    All packages built successfully! (All logs)

  • cppcheck/2.7.5@:
    All packages built successfully! (All logs)

@Sneder89
Copy link
Contributor Author

Nice job @Sneder89 ! 🎉

Thanks!

@Sneder89 Sneder89 requested review from MartinDelille and removed request for uilianries November 28, 2022 18:51
@conan-center-bot conan-center-bot merged commit afcf3ba into conan-io:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries left review comments

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@MartinDelille MartinDelille MartinDelille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sneder89 @conan-center-bot @MartinDelille @mjvankampen @uilianries @prince-chrismc