Add wavelet_buffer v0.4.0 #13722

victor1234 · 2022-10-24T12:54:31Z

Library name: wavelet_buffer/0.4.0
Description: A universal C++ compression library based on wavelet transformation
License: MPL-2.0
Link: https://github.com/panda-official/WaveletBuffer

I'm one of the library developers. It's a open source project and we want to share it on public conan repo.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2022-10-24T12:54:37Z

All committers have signed the CLA.

SpaceIm · 2022-11-17T11:00:09Z

recipes/wavelet_buffer/all/conanfile.py

+    settings = "os", "compiler", "build_type", "arch"
+    options = {"shared": [True, False], "fPIC": [True, False]}
+
+    def requirements(self):


move requirements after configure please

SpaceIm · 2022-11-17T11:03:28Z

Upstream CMakeLists downloads SfCompressor during configuration, CCI policies don't allow to download something at build time: https://github.com/panda-official/WaveletBuffer/blob/develop/CMakeLists.txt#L68-L75

uilianries · 2022-11-29T08:53:01Z

It requires #13917 first

prince-chrismc · 2022-12-07T23:20:25Z

The required PR seems to merged so lets see what happens on a new build :)

conan-center-bot · 2022-12-08T03:46:05Z

Conan v1 pipeline

All green in build 21 (115c3666700183a9ce9f34ecd8fbc991fed475e7):

wavelet_buffer/0.4.0@:
All packages built successfully! (All logs)

victor1234 · 2022-12-08T19:29:49Z

The required PR seems to merged so lets see what happens on a new build :)

What should I do?

SpaceIm · 2022-12-09T12:13:53Z

recipes/wavelet_buffer/all/conanfile.py

+    default_options = {
+        "cimg/*:enable_fftw": False,
+        "cimg/*:enable_jpeg": False,
+        "cimg/*:enable_openexr": False,
+        "cimg/*:enable_png": False,
+        "cimg/*:enable_tiff": False,
+        "cimg/*:enable_ffmpeg": False,
+        "cimg/*:enable_opencv": False,
+        "shared": False,
+        "fPIC": True,
+    }
+
+    # Binary configuration
+    settings = "os", "compiler", "build_type", "arch"
+    options = {"shared": [True, False], "fPIC": [True, False]}


Suggested change

default_options = {

"cimg/*:enable_fftw": False,

"cimg/*:enable_jpeg": False,

"cimg/*:enable_openexr": False,

"cimg/*:enable_png": False,

"cimg/*:enable_tiff": False,

"cimg/*:enable_ffmpeg": False,

"cimg/*:enable_opencv": False,

"shared": False,

"fPIC": True,

}

# Binary configuration

settings = "os", "compiler", "build_type", "arch"

options = {"shared": [True, False], "fPIC": [True, False]}

settings = "os", "arch", "compiler", "build_type"

options = {

"shared": [True, False],

"fPIC": [True, False],

}

default_options = {

"shared": False,

"fPIC": True,

}

SpaceIm · 2022-12-09T12:17:31Z

Upstream CMakeLists downloads SfCompressor during configuration, CCI policies don't allow to download something at build time: https://github.com/panda-official/WaveletBuffer/blob/develop/CMakeLists.txt#L68-L75

Kindly remind that it should be a no go according to CCI policies.

SpaceIm · 2022-12-09T12:14:18Z

recipes/wavelet_buffer/all/conanfile.py

+
+import os
+
+required_conan_version = ">=1.50"


Suggested change

required_conan_version = ">=1.50"

required_conan_version = ">=1.53"

recipes/wavelet_buffer/all/conanfile.py

SpaceIm · 2022-12-09T12:18:33Z

recipes/wavelet_buffer/all/conanfile.py

+        # Dependency options check
+        cimg = self.dependencies["cimg"]
+        if cimg.options.enable_fftw:
+            raise ConanInvalidConfiguration(
+                f"{self.ref} requires the option 'cimg:enable_fftw=False'"
+            )
+        if cimg.options.enable_jpeg:
+            raise ConanInvalidConfiguration(
+                f"{self.ref} requires the option 'cimg:enable_jpeg=False'"
+            )
+        if cimg.options.enable_openexr:
+            raise ConanInvalidConfiguration(
+                f"{self.ref} requires the option 'cimg:enable_openexr=False'"
+            )
+        if cimg.options.enable_tiff:
+            raise ConanInvalidConfiguration(
+                f"{self.ref} requires the option 'cimg:enable_tiff=False'"
+            )
+        if cimg.options.enable_png:
+            raise ConanInvalidConfiguration(
+                f"{self.ref} requires the option 'cimg:enable_png=False'"
+            )
+        if cimg.options.enable_ffmpeg:
+            raise ConanInvalidConfiguration(
+                f"{self.ref} requires the option 'cimg:enable_ffmpeg=False'"
+            )
+        if cimg.options.enable_opencv:
+            raise ConanInvalidConfiguration(
+                f"{self.ref} requires the option 'cimg:enable_opencv=False'"
+            )
+


Suggested change

# Dependency options check

cimg = self.dependencies["cimg"]

if cimg.options.enable_fftw:

raise ConanInvalidConfiguration(

f"{self.ref} requires the option 'cimg:enable_fftw=False'"

)

if cimg.options.enable_jpeg:

raise ConanInvalidConfiguration(

f"{self.ref} requires the option 'cimg:enable_jpeg=False'"

)

if cimg.options.enable_openexr:

raise ConanInvalidConfiguration(

f"{self.ref} requires the option 'cimg:enable_openexr=False'"

)

if cimg.options.enable_tiff:

raise ConanInvalidConfiguration(

f"{self.ref} requires the option 'cimg:enable_tiff=False'"

)

if cimg.options.enable_png:

raise ConanInvalidConfiguration(

f"{self.ref} requires the option 'cimg:enable_png=False'"

)

if cimg.options.enable_ffmpeg:

raise ConanInvalidConfiguration(

f"{self.ref} requires the option 'cimg:enable_ffmpeg=False'"

)

if cimg.options.enable_opencv:

raise ConanInvalidConfiguration(

f"{self.ref} requires the option 'cimg:enable_opencv=False'"

)

Not a usage requirement

SpaceIm · 2022-12-09T12:26:19Z

recipes/wavelet_buffer/all/conanfile.py

+    @property
+    def _minimum_cpp_standard(self):
+        return 20
+
+    @property
+    def _minimum_compilers_version(self):
+        return {
+            "gcc": "8",
+            "clang": "12",
+            "apple-clang": "12",
+        }
+
+    def validate(self):
+        if self.info.settings.compiler.get_safe("cppstd"):
+            check_min_cppstd(self, self._minimum_cpp_standard)
+
+        # Compiler version check
+        check_min_vs(self, 192)
+        if not is_msvc(self):
+            minimum_version = self._minimum_compilers_version.get(
+                str(self.info.settings.compiler), False
+            )
+            if not minimum_version:
+                self.output.warn(
+                    "{} recipe lacks information about the {} compiler support.".format(
+                        self.name, self.settings.compiler
+                    )
+                )
+            else:
+                if Version(self.info.settings.compiler.version) < minimum_version:
+                    raise ConanInvalidConfiguration(
+                        "{} requires C++{} support. The current compiler {} {} does not support it.".format(
+                            self.ref,
+                            self._minimum_cpp_standard,
+                            self.settings.compiler,
+                            self.settings.compiler.version,
+                        )
+                    )


Suggested change

@property

def _minimum_cpp_standard(self):

return 20

@property

def _minimum_compilers_version(self):

return {

"gcc": "8",

"clang": "12",

"apple-clang": "12",

}

def validate(self):

if self.info.settings.compiler.get_safe("cppstd"):

check_min_cppstd(self, self._minimum_cpp_standard)

# Compiler version check

check_min_vs(self, 192)

if not is_msvc(self):

minimum_version = self._minimum_compilers_version.get(

str(self.info.settings.compiler), False

)

if not minimum_version:

self.output.warn(

"{} recipe lacks information about the {} compiler support.".format(

self.name, self.settings.compiler

)

)

else:

if Version(self.info.settings.compiler.version) < minimum_version:

raise ConanInvalidConfiguration(

"{} requires C++{} support. The current compiler {} {} does not support it.".format(

self.ref,

self._minimum_cpp_standard,

self.settings.compiler,

self.settings.compiler.version,

)

)

@property

def _min_cppstd(self):

return 20

@property

def _minimum_compilers_version(self):

return {

"gcc": "8",

"clang": "12",

"apple-clang": "12",

"Visual Studio": "16",

"msvc": "192",

}

def validate(self):

if self.settings.compiler.get_safe("cppstd"):

check_min_cppstd(self, self._min_cppstd)

minimum_version = self._minimum_compilers_version.get(str(self.settings.compiler))

if minimum_version and Version(self.settings.compiler.version) < minimum_version:

raise ConanInvalidConfiguration(

f"{self.ref} requires C++{self._min_cppstd}, which your compiler does not support."

)

SpaceIm · 2022-12-09T12:26:38Z

recipes/wavelet_buffer/all/conanfile.py

+                        )
+                    )
+
+        if is_msvc(self) and self.info.options.shared:


Suggested change

if is_msvc(self) and self.info.options.shared:

if is_msvc(self) and self.options.shared:

SpaceIm · 2022-12-09T12:27:11Z

recipes/wavelet_buffer/all/test_package/conanfile.py

+from conan.tools.cmake import CMake
+from conan.tools.layout import cmake_layout


Suggested change

from conan.tools.cmake import CMake

from conan.tools.layout import cmake_layout

from conan.tools.cmake import CMake, cmake_layout

SpaceIm · 2022-12-09T12:27:29Z

recipes/wavelet_buffer/all/conanfile.py

+from conan import ConanFile
+from conan.tools.cmake import CMakeToolchain, CMakeDeps, CMake, cmake_layout
+from conan.tools.files import get, copy, rmdir
+from conan.tools.microsoft import check_min_vs, is_msvc


Suggested change

from conan.tools.microsoft import check_min_vs, is_msvc

from conan.tools.microsoft import is_msvc

SpaceIm · 2022-12-09T12:27:58Z

recipes/wavelet_buffer/all/test_v1_package/conanfile.py

+import os
+
+
+# legacy validation with Conan 1.x


Suggested change

# legacy validation with Conan 1.x

SpaceIm · 2022-12-09T12:28:18Z

recipes/wavelet_buffer/all/test_package/conanfile.py

+from conan.tools.layout import cmake_layout
+
+
+class HelloTestConan(ConanFile):


Suggested change

class HelloTestConan(ConanFile):

class TestPackageConan(ConanFile):

victor1234 · 2022-12-11T08:25:33Z

@SpaceIm I missed your posts due unset notifications
Should I recreate PR?

SpaceIm · 2022-12-11T09:04:23Z

I've opened #14657

* address reviews in #13722 * add FIXME about SfCompressor downloaded at build time * bump libjpeg-turbo * typo * remove openblas from dependencies * expose blaze as a public dependency for conan v2 * typo * allow to select libjpeg implementation & link to libjpeg only * raise for msvc shared in validate_build() * add cmake to tool_requires * move back msvc shared check to validate()

…-index * 'develop' of octocat.dlogics.com:datalogics/conan-center-index: (6046 commits) cmake: Remove the private tag from the openssl requirement (conan-io#14689) doctest: Use self.info.clear() instead of header_only() (conan-io#14684) imath: add version 3.1.6 (conan-io#14679) tgbot: add version 1.5 (conan-io#14672) luau: add version 0.556 (conan-io#14673) fast_double_parser: add version 0.7.0 (conan-io#14664) sqlite_orm: add version 1.8 (conan-io#14663) magic_enum: add version 0.8.2 (conan-io#14658) Update changelog 09-December-2022 (conan-io#14525) Add Boost.LEAF to Conan Center (conan-io#13722) Add wavelet_buffer v0.4.0 (conan-io#14655) etl: add version 20.35.5 (conan-io#14654) nss 3.86 (conan-io#14652) flatbuffers: add version 22.12.06 (conan-io#14427) libxml2: fix CMake vars in CMakeDeps & bump icu (conan-io#14626) [googleapis] Use is_msvc to abstract away compiler name setting (conan-io#14619) (conan-io#14620) libzip: Use robust github mirror (conan-io#14617) pybind11_json: add version 0.2.13 (conan-io#14476) add libhydrogen/cci.20221115 (conan-io#13917) cimg: conan v2 support + bump dependencies + disable dependencies by default ...

Add wavelet_buffer v0.4.0

99f544f

conan-center-bot added the Failed label Oct 24, 2022

This comment has been minimized.

Sign in to view

Fix for linter

3425c6f

This comment has been minimized.

Sign in to view

victor1234 added 2 commits October 25, 2022 13:39

Fix for linter

fabf98f

Fix for linter

f306d37

This comment has been minimized.

Sign in to view

victor1234 added 3 commits October 25, 2022 15:45

Fix fPic

9d36a49

Fix fPic

cab3bdc

Fix import

9f3f2aa

This comment has been minimized.

Sign in to view

Fix compiler version check

659871f

conan-center-bot added Service Under Maintenance and removed Failed labels Oct 27, 2022

This comment has been minimized.

Sign in to view

Fix for conan hook

564ae6a

conan-center-bot added Failed and removed Service Under Maintenance labels Oct 27, 2022

This comment has been minimized.

Sign in to view

Bump compilers version

52ff8be

conan-center-bot removed the Failed label Oct 27, 2022

This comment has been minimized.

Sign in to view

victor1234 marked this pull request as ready for review October 28, 2022 08:57

victor1234 requested a review from uilianries November 11, 2022 19:17

SpaceIm reviewed Nov 17, 2022

View reviewed changes

conan-center-bot requested a review from jcar87 November 22, 2022 12:00

uilianries added the blocked Affected by an external issue and waiting until it is solved label Nov 29, 2022

conan-center-bot requested a review from franramirez688 December 1, 2022 12:10

prince-chrismc closed this Dec 7, 2022

prince-chrismc reopened this Dec 7, 2022

prince-chrismc removed the blocked Affected by an external issue and waiting until it is solved label Dec 7, 2022

uilianries approved these changes Dec 9, 2022

View reviewed changes

SpaceIm reviewed Dec 9, 2022

View reviewed changes

SpaceIm suggested changes Dec 9, 2022

View reviewed changes

conan-center-bot merged commit a076f03 into conan-io:master Dec 9, 2022

SpaceIm reviewed Dec 9, 2022

View reviewed changes

SpaceIm added a commit to SpaceIm/conan-center-index that referenced this pull request Dec 9, 2022

address reviews in conan-io#13722

ef3ac7d

SpaceIm mentioned this pull request Dec 9, 2022

wavelet_buffer: address reviews in #13722 #14657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wavelet_buffer v0.4.0 #13722

Add wavelet_buffer v0.4.0 #13722

victor1234 commented Oct 24, 2022 •

edited

Loading

CLAassistant commented Oct 24, 2022 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm Nov 17, 2022

SpaceIm commented Nov 17, 2022 •

edited

Loading

uilianries commented Nov 29, 2022

prince-chrismc commented Dec 7, 2022

conan-center-bot commented Dec 8, 2022

victor1234 commented Dec 8, 2022

SpaceIm Dec 9, 2022

SpaceIm commented Dec 9, 2022

SpaceIm Dec 9, 2022

SpaceIm Dec 9, 2022

SpaceIm Dec 9, 2022

SpaceIm Dec 9, 2022

SpaceIm Dec 9, 2022

SpaceIm Dec 9, 2022

SpaceIm Dec 9, 2022

SpaceIm Dec 9, 2022

SpaceIm Dec 9, 2022

victor1234 commented Dec 11, 2022

SpaceIm commented Dec 11, 2022

	required_conan_version = ">=1.50"
	required_conan_version = ">=1.53"

	if is_msvc(self) and self.info.options.shared:
	if is_msvc(self) and self.options.shared:

		from conan.tools.cmake import CMake
		from conan.tools.layout import cmake_layout

	from conan.tools.cmake import CMake
	from conan.tools.layout import cmake_layout
	from conan.tools.cmake import CMake, cmake_layout

	from conan.tools.microsoft import check_min_vs, is_msvc
	from conan.tools.microsoft import is_msvc

		from conan.tools.layout import cmake_layout


		class HelloTestConan(ConanFile):

	class HelloTestConan(ConanFile):
	class TestPackageConan(ConanFile):

Add wavelet_buffer v0.4.0 #13722

Add wavelet_buffer v0.4.0 #13722

Conversation

victor1234 commented Oct 24, 2022 • edited Loading

CLAassistant commented Oct 24, 2022 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

SpaceIm commented Nov 17, 2022 • edited Loading

uilianries commented Nov 29, 2022

prince-chrismc commented Dec 7, 2022

conan-center-bot commented Dec 8, 2022

Conan v1 pipeline

victor1234 commented Dec 8, 2022

Choose a reason for hiding this comment

SpaceIm commented Dec 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor1234 commented Dec 11, 2022

SpaceIm commented Dec 11, 2022

victor1234 commented Oct 24, 2022 •

edited

Loading

CLAassistant commented Oct 24, 2022 •

edited

Loading

SpaceIm commented Nov 17, 2022 •

edited

Loading