Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[anyrpc] Add new recipe #13717

Merged
merged 21 commits into from
Oct 28, 2022
Merged

[anyrpc] Add new recipe #13717

merged 21 commits into from
Oct 28, 2022

Conversation

fdgStilla
Copy link
Contributor

@fdgStilla fdgStilla commented Oct 24, 2022

Specify library name and version: anyrpc /1.0.2

I will need this library to integrate spix (https://github.com/faaxm/spix), I am not the author of any of these repos.

fixes #13716


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@fdgStilla fdgStilla changed the title Add anyrpc package [anyrpc] Add new recipe Oct 24, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, only few comments.

recipes/anyrpc/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/anyrpc/all/test_package/test_anyrpc.cpp Outdated Show resolved Hide resolved
@fdgStilla
Copy link
Contributor Author

@uilianries I am creating a recipe for Spix https://github.com/faaxm/spix (that's why I created anyrpc which is a dependency).
However I realize that it requires Quick module from qt, which is not available in the package provided by conancenter, you have to set the option qt:qtdeclarative to True, which is False by default.
Do you know how to proceed ? Can I upload a spix recipe on conancenter without any package built ? Will the CI agree ?

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

Do you know how to proceed ? Can I upload a spix recipe on conancenter without any package built ? Will the CI agree ?

@fdgStilla Add that required option to validate() and raise ConanInvalidConfiguration when not configured according to your need. The CI accepts zero packages and only the recipe. Your case is not the first and unfortunately, we can't generate custom packages to fit your package.

@fdgStilla
Copy link
Contributor Author

@fdgStilla Add that required option to validate() and raise ConanInvalidConfiguration when not configured according to your need. The CI accepts zero packages and only the recipe. Your case is not the first and unfortunately, we can't generate custom packages to fit your package.

Ok I will create another PR for spix with a correct validate method after this PR.
Can you approve this PR? Thanks!

@fdgStilla fdgStilla requested a review from uilianries October 27, 2022 10:59
uilianries
uilianries previously approved these changes Oct 27, 2022
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Just a few small details.

recipes/anyrpc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/anyrpc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/anyrpc/all/test_v1_package/CMakeLists.txt Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 34ea1f4
anyrpc/1.0.2
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libanyrpc.so' links to system library 'm' but it is not in cpp_info.system_libs.

Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one more lint thing pop up. The recipe looks top-notch. Thanks for working on this!

recipes/anyrpc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/anyrpc/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 11 (23ca683285f17ebdfdbfe7ec0d4ecf84f2192d49):

  • anyrpc/1.0.2@:
    All packages built successfully! (All logs)

Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conan-center-bot conan-center-bot merged commit 1022097 into conan-io:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] anyrpc/1.0.2
4 participants