-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[anyrpc] Add new recipe #13717
[anyrpc] Add new recipe #13717
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, only few comments.
@uilianries I am creating a recipe for Spix https://github.com/faaxm/spix (that's why I created anyrpc which is a dependency). |
This comment has been minimized.
This comment has been minimized.
@fdgStilla Add that required option to |
Ok I will create another PR for spix with a correct validate method after this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Just a few small details.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 34ea1f4anyrpc/1.0.2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed one more lint thing pop up. The recipe looks top-notch. Thanks for working on this!
Conan v1 pipelineAll green in build 11 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Specify library name and version: anyrpc /1.0.2
I will need this library to integrate spix (https://github.com/faaxm/spix), I am not the author of any of these repos.
fixes #13716