libgsasl: add libgsasl/2.2.0 #13711

kexianda · 2022-10-24T02:22:06Z

ligbsasl/2.2.0

gsasl is widely used.
add a recipe for it.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

jwillikers · 2022-10-24T11:20:11Z

recipes/libgsasl/all/conanfile.py

+
+    def validate(self):
+        # Currently tested only on Linux platform.
+        if self.settings.os == "Windows" or self.settings.os == "Macos":


Suggested change

if self.settings.os == "Windows" or self.settings.os == "Macos":

if self.info.settings.os in ["Macos", "Windows"]:

jwillikers · 2022-10-24T11:21:27Z

recipes/libgsasl/all/conanfile.py

+    description = "Portable gsasl C library"
+    url = "https://github.com/conan-io/conan-center-index"
+    homepage = "https://www.gnu.org/software/gsasl/"
+    license = "BSD-3-Clause"


The library itself is licensed under the LGPL. The command-line utility and tests are licensed under the GPL.

Suggested change

license = "BSD-3-Clause"

license = "LGPL-2.1-or-later"

jwillikers · 2022-10-24T11:23:00Z

recipes/libgsasl/all/conanfile.py

+    url = "https://github.com/conan-io/conan-center-index"
+    homepage = "https://www.gnu.org/software/gsasl/"
+    license = "BSD-3-Clause"
+    topics = ("libgsasl")


The library's name shouldn't be reproduced in the topics.

Suggested change

topics = ("libgsasl")

topics = "authentication", "gnu", "security"

jwillikers · 2022-10-24T11:24:03Z

recipes/libgsasl/all/conanfile.py

+
+class LibgsaslConan(ConanFile):
+    name = "libgsasl"
+    description = "Portable gsasl C library"


Suggested change

description = "Portable gsasl C library"

description = "An implementation of the Simple Authentication and Security Layer framework and a few common SASL mechanisms"

jwillikers · 2022-10-24T11:24:44Z

recipes/libgsasl/all/conanfile.py

+    requires = ("libiconv/1.17",
+                "libidn/1.36"
+                )


These should be moved to the requirements() method.

jwillikers · 2022-10-24T11:26:04Z

recipes/libgsasl/all/conanfile.py

+        copy(self, "ABOUT-NLS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
+        copy(self, "NEWS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
+        copy(self, "AUTHORS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
+        copy(self, "COPYING", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
+        copy(self, "COPYING.LIB", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
+        copy(self, "README", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))
+        copy(self, "THANKS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))


This should just be the licenses, I believe.

Suggested change

copy(self, "ABOUT-NLS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

copy(self, "NEWS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

copy(self, "AUTHORS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

copy(self, "COPYING", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

copy(self, "COPYING.LIB", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

copy(self, "README", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

copy(self, "THANKS", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

copy(self, "COPYING", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

copy(self, "COPYING.LIB", src=self.source_folder, dst=os.path.join(self.package_folder, "licenses"))

uilianries · 2022-10-24T13:53:32Z

recipes/libgsasl/all/conanfile.py

+from conan import ConanFile
+from conan.errors import ConanInvalidConfiguration
+from conan.tools.apple import fix_apple_shared_install_name
+from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, rm, rmdir


Suggested change

from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, rm, rmdir

from conan.tools.files import copy, get, rm, rmdir

NO patches needed

uilianries · 2022-10-24T13:56:22Z

recipes/libgsasl/all/conanfile.py

+from conan.tools.layout import basic_layout
+import os
+
+required_conan_version = ">=1.52.0"


Suggested change

required_conan_version = ">=1.52.0"

required_conan_version = ">=1.50.0"

1.51.3 more than enough without export_conandata_patches

uilianries · 2022-10-24T13:56:37Z

recipes/libgsasl/all/conanfile.py

+    description = "GNU Simple Authentication and Security Layer"
+    settings = "os", "compiler", "build_type", "arch"
+    options = {
+        "shared": [True, False],


uilianries · 2022-10-24T13:58:28Z

recipes/libgsasl/all/conandata.yml

@@ -0,0 +1,7 @@
+sources:
+  "1.8.0":


Do you need both versions? Otherwise, keep only the latest. We try to avoid extra versions which are not directly requested by users.

conan-center-bot · 2022-11-04T09:18:22Z

Conan v1 pipeline

Failure in build 5 (588be503f4c9579f2c70a17deebdde931046b6eb):

libgsasl/1.8.0@:
Error running command conan export recipes/libgsasl/all/conanfile.py libgsasl/1.8.0@:

[HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
[HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
[HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
[HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
[HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 4.966796875 KB
[HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
[HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
[HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
[HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
[HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
[HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
[HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
[HOOK - conan-center.py] pre_export(): [NOT ALLOWED ATTRIBUTES (KB-H039)] OK
[HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
[HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
[HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
[HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
[HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
[HOOK - conan-center.py] pre_export(): [CONFIG.YML HAS NEW VERSION (KB-H052)] OK
[HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
[HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS RENAME (KB-H057)] OK
[HOOK - conan-center.py] pre_export(): [ILLEGAL CHARACTERS (KB-H058)] OK
[HOOK - conan-center.py] pre_export(): [CLASS NAME (KB-H059)] OK
[HOOK - conan-center.py] pre_export(): [NO CRLF (KB-H060)] OK
[HOOK - conan-center.py] pre_export(): [NO BUILD SYSTEM FUNCTIONS (KB-H061)] OK
[HOOK - conan-center.py] pre_export(): [TOOLS CROSS BUILDING (KB-H062)] OK
[HOOK - conan-center.py] pre_export(): [INVALID TOPICS (KB-H064)] OK
[HOOK - conan-center.py] pre_export(): [NO REQUIRED_CONAN_VERSION (KB-H065)] OK
[HOOK - conan-center.py] pre_export(): [TEST_TYPE MANAGEMENT (KB-H068)] OK
[HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO DEFAULT OPTIONS (KB-H069)] OK
[HOOK - conan-center.py] pre_export(): [MANDATORY SETTINGS (KB-H070)] OK
[HOOK - conan-center.py] pre_export(): [PYLINT EXECUTION (KB-H072)] OK
[HOOK - conan-center.py] pre_export(): WARN: [FPIC OPTION (KB-H006)] This recipe does not include an 'fPIC' option. Make sure you are using the right casing
[HOOK - conan-center.py] pre_export(): ERROR: [TEST V1 PACKAGE FOLDER (KB-H073)] The test_package seems be prepared for Conan v2, but test_v1_package is missing. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H073) 
ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

uilianries · 2022-11-07T11:14:15Z

[HOOK - conan-center.py] pre_export(): ERROR: [TEST V1 PACKAGE FOLDER (KB-H073)] The test_package seems be prepared for Conan v2, but test_v1_package is missing. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H073)

Please, add a test_v1_package based on https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/autotools_package/all/test_v1_package

stale · 2022-12-11T12:40:54Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2023-01-16T19:06:32Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

conan-center-bot added the Failed label Oct 24, 2022

This comment has been minimized.

Sign in to view

kexianda changed the title ~~libgsasl: add ligbsasl/2.2.0~~ libgsasl: add liggsasl/2.2.0 Oct 24, 2022

kexianda changed the title ~~libgsasl: add liggsasl/2.2.0~~ libgsasl: add libgsasl/2.2.0 Oct 24, 2022

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label Oct 24, 2022

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Oct 24, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

jwillikers suggested changes Oct 24, 2022

View reviewed changes

uilianries reviewed Oct 24, 2022

View reviewed changes

kexianda force-pushed the gsasl branch from 93b8acd to 588be50 Compare November 4, 2022 09:16

libgsasl recipe

588be50

conan-center-bot added the Failed label Nov 4, 2022

stale bot added the stale label Dec 11, 2022

stale bot closed this Jan 16, 2023

valgur mentioned this pull request Jan 26, 2024

Stale recipe PRs possibly worth another look #22553

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libgsasl: add libgsasl/2.2.0 #13711

libgsasl: add libgsasl/2.2.0 #13711

kexianda commented Oct 24, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jwillikers Oct 24, 2022

jwillikers Oct 24, 2022

jwillikers Oct 24, 2022

jwillikers Oct 24, 2022

jwillikers Oct 24, 2022

jwillikers Oct 24, 2022

uilianries Oct 24, 2022

uilianries Oct 24, 2022

uilianries Oct 24, 2022

uilianries Oct 24, 2022

conan-center-bot commented Nov 4, 2022

uilianries commented Nov 7, 2022

stale bot commented Dec 11, 2022

stale bot commented Jan 16, 2023

	if self.settings.os == "Windows" or self.settings.os == "Macos":
	if self.info.settings.os in ["Macos", "Windows"]:

	topics = ("libgsasl")
	topics = "authentication", "gnu", "security"

	description = "Portable gsasl C library"
	description = "An implementation of the Simple Authentication and Security Layer framework and a few common SASL mechanisms"

	from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, rm, rmdir
	from conan.tools.files import copy, get, rm, rmdir

	required_conan_version = ">=1.52.0"
	required_conan_version = ">=1.50.0"

libgsasl: add libgsasl/2.2.0 #13711

libgsasl: add libgsasl/2.2.0 #13711

Conversation

kexianda commented Oct 24, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Nov 4, 2022

Conan v1 pipeline

uilianries commented Nov 7, 2022

stale bot commented Dec 11, 2022

stale bot commented Jan 16, 2023