opencl-icd-loader: add 2022.05.18 + conan v2 support #13697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
previously approved these changes
Oct 24, 2022
jwillikers
suggested changes
Oct 24, 2022
| @@ -1,31 +1,35 @@ | |||
| from conans import ConanFile, CMake, tools | |||
| from conan import ConanFile, conan_version | |||
There was a problem hiding this comment.
Sounds like you're supposed to remove the conan_version here.
There was a problem hiding this comment.
Thank you for catching it :)
jwillikers
previously approved these changes
Oct 24, 2022
prince-chrismc
previously approved these changes
Oct 24, 2022
This comment has been minimized.
This comment has been minimized.
ed6ed8e
|
All green in build 5 (
|
jwillikers
approved these changes
Oct 25, 2022
uilianries
reviewed
Oct 25, 2022
|
|
||
| def package_info(self): | ||
| self.cpp_info.set_property("cmake_find_mode", "both") |
There was a problem hiding this comment.
Why cmake_find_mode:both is required here?
There was a problem hiding this comment.
prince-chrismc
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!