Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: Fix libdir for PkgConfigDeps #13645

Merged

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: glib/*

Required to update gstreamer to use PkgConfigDeps: #13400.

Related issue is here: conan-io/conan#12279.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Oct 20, 2022

I detected other pull requests that are modifying glib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 20, 2022

Duplicate of #13440. Anyway a fix to PkgConfigDeps would require a test of PkgConfigDeps, and you will hit the same issue than me: #13440 (comment)

@conan-center-bot
Copy link
Collaborator

All green in build 1 (9ec8b654283b28967169ca51e880ede0b617c7c6):

  • glib/2.68.3@:
    All packages built successfully! (All logs)

  • glib/2.69.3@:
    All packages built successfully! (All logs)

  • glib/2.72.1@:
    All packages built successfully! (All logs)

  • glib/2.71.3@:
    All packages built successfully! (All logs)

  • glib/2.70.4@:
    All packages built successfully! (All logs)

  • glib/2.73.0@:
    All packages built successfully! (All logs)

  • glib/2.74.0@:
    All packages built successfully! (All logs)

  • glib/2.73.1@:
    All packages built successfully! (All logs)

  • glib/2.73.2@:
    All packages built successfully! (All logs)

  • glib/2.73.3@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 9ec8b65
glib/2.68.3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libglib-2.0.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot merged commit 1d92326 into conan-io:master Oct 25, 2022
@jwillikers jwillikers deleted the glib-pkg-config-deps-libdir branch October 25, 2022 16:11
@planetmarshall
Copy link
Contributor

This does not appear to be fixed? glib-2.0.pc contains:

prefix=/home/andrew/.conan/data/glib/2.73.3/_/_/package/eb34e48f59e3766360e3256bde88ef47a36ecfe0
libdir1=${prefix}/lib
includedir1=${prefix}/include
includedir2=${prefix}/include/glib-2.0
includedir3=${prefix}/lib/glib-2.0/include
# Custom PC content
bindir=${prefix}/bin
glib_genmarshal=${bindir}/glib-genmarshal
gobject_query=${bindir}/gobject-query
glib_mkenums=${bindir}/glib-mkenums

Name: glib-2.0
Description: Conan component: glib-glib-2.0
Version: 2.73.3
Libs: -L"${libdir1}" -lglib-2.0 -lpthread 
Cflags: -I"${includedir1}" -I"${includedir2}" -I"${includedir3}" 
Requires: libpcre2

libdir and includedir are missing, which are required by downstream recipes.

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 24, 2022

libdir & includedir are an internal detail of a pkgconfig file. What really matters is Libs, Cflags etc. If you really want libdir & includedir variables, it would require a PR on conan client side.

@jwillikers
Copy link
Contributor Author

jwillikers commented Nov 25, 2022

@planetmarshall @SpaceIm is right, fixes specific to the GLIB recipe would just be a temporary band-aid. Better to fix the issue in Conan for all such scenarios. I submitted the issue conan-io/conan#12279 for this some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants