Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libevent: build either shared or static #13576

Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 18, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (63bc0dba7018cc421513e7c104586bdfbe0d9661):

  • libevent/2.1.12@:
    All packages built successfully! (All logs)

  • libevent/2.1.11@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 18, 2022

FYI, the issue was reported on slack: https://cpplang.slack.com/archives/C41CWV9HA/p1666088803439519. tc.variables doesn't seem to override values of variables defined as CACHE variables in upstream CMakeLists (see conan-io/conan#11937 if you want more explanation): https://github.com/libevent/libevent/blob/8f47d8de281b877450474734594fdc0a60ee35d1/CMakeLists.txt#L42-L43

@prince-chrismc
Copy link
Contributor

One more thing to look at when we review 🙈

@conan-center-bot conan-center-bot merged commit 23b6941 into conan-io:master Oct 18, 2022
@SpaceIm SpaceIm deleted the fix/libevent-static-or-shared branch October 18, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants