Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libffi: Support Conan V2 #13355

Merged
merged 47 commits into from
Oct 24, 2022
Merged

libffi: Support Conan V2 #13355

merged 47 commits into from
Oct 24, 2022

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: libffi/*

Forked off of #12904.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

jellespijker and others added 12 commits October 7, 2022 15:17
@jellespijker @jwillikers
Added Conan v2 support
b6a5f2c 
Based on this template:
https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/autotools_package

Contribute to CURA-9628
@jwillikers
catch ValueError instead of broad Exception catch
c468c84 
Contributes to CURA-9628
@jellespijker @jwillikers
Validating not needed in this recipe
d19abd5 
Contributes to CURA-9628
@jellespijker @jwillikers
Clean-up various path references
8077e01 
Contributes to CURA-9628
@jellespijker @jwillikers
Use modern apple rpath fix
d945949 
Contributes to CURA-9628
@jellespijker @jwillikers
Reapplied patches again
02d6ace 
Contributes to CURA-9628
@jwillikers
convert Path to str before passing to unix_path
35126ea 
Contributes to CURA-9628
@jwillikers
Removed clang exception in generate
3188330 
Contributes to CURA-9628
@jellespijker @jwillikers
Use user_info.ar_lib as a workaround
5021f70 
Should be reverted once conan-io#12898
has been merged

Contribute to CURA-9628 and CURA-9575
@jellespijker @jwillikers
disable multi os directory when compiling with apple-clang
98a8c71 
Contributes to CURA-9628
@jellespijker @jwillikers
Use conf for AR variable
d56e09d 
Contributes to CURA-9628
@jwillikers
Slight clean up
09263f5
@jwillikers jwillikers changed the title libffi: Support Conan V2 Draft: libffi: Support Conan V2 Oct 7, 2022
@jwillikers jwillikers marked this pull request as draft October 7, 2022 20:38
@jwillikers jwillikers changed the title Draft: libffi: Support Conan V2 libffi: Support Conan V2 Oct 7, 2022
This was referenced Oct 7, 2022
Closed
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers jwillikers force-pushed the libffi-v2 branch 2 times, most recently from f76b4a3 to 651cbba Compare October 9, 2022 16:48
@jwillikers jwillikers marked this pull request as ready for review October 10, 2022 02:01
@github-actions github-actions bot mentioned this pull request Oct 10, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers
Copy link
Contributor Author

Oh, I bet this is related to conan-io/conan#11867.

@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 12, 2022

Oh, I bet this is related to conan-io/conan#11867.

How? I see Visual Studio errors in this PR, so it's not related to conan-io/conan#11867

@jwillikers jwillikers mentioned this pull request Oct 20, 2022
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers jwillikers closed this Oct 21, 2022
@jwillikers jwillikers reopened this Oct 21, 2022
@planetmarshall planetmarshall mentioned this pull request Oct 21, 2022
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@jwillikers
Try patching version 3.2.1
f15d3e4
@jwillikers
Revert "Try patching version 3.2.1"
33dd7ee 
This reverts commit f15d3e4.
@jwillikers
Drop version 3.2.1
828566a 
This is no longer building and I don't know why.
It's also from 2014, so hopefully it's okay to drop.
@jwillikers
Copy link
Contributor Author

Version 3.2.1 is causing a bit of trouble on Windows and I don't want to pull forward a bunch of Windows-related patches for the msvcpp.sh wrapper. I'm dropping 3.2.1 to get this working, but let me know if we need to keep that version.

@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc previously approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits

recipes/libffi/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libffi/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libffi/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libffi/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 39 (9eb26830471cbb4ad81f59251a52194cf4ef2b40):

  • libffi/3.4.2@:
    All packages built successfully! (All logs)

  • libffi/3.3@:
    All packages built successfully! (All logs)

  • libffi/3.4.3@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 0bab4d3 into conan-io:master Oct 24, 2022
@jwillikers jwillikers deleted the libffi-v2 branch October 24, 2022 20:47
@prince-chrismc prince-chrismc mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm left review comments

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jwillikers @conan-center-bot @SpaceIm @uilianries @prince-chrismc @jellespijker