Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document working locally + Conan 2.0 commands #13102

Merged
merged 13 commits into from
Oct 6, 2022

Conversation

prince-chrismc
Copy link
Contributor

Docs!

🌟 Goal

  • Consolidate all the information and commands to one file
    • Have one recipe that people can use as a reference and test to make sure they are correctly setup

I also snuck in

  • some format and link fixes
  • tidy in contributing
  • moved labels all to one place

I also snuck in some format and link fixes
@prince-chrismc
Copy link
Contributor Author

Don't hesitate to leave feedback!

If you have a better way please let me know ❤️


### Try it yourself

For instance you can create packages for `fmt` in various supported configurations by running:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to purpose fmt as the standard example... its quick to build and has all the configuration supported by CCI and no deps so it should always work 🤞

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt is a good choice.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice

docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Show resolved Hide resolved

```sh
cd recipes/fmt
conan create all/conanfile.py --version 9.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not dual profile mandatory for Conan 2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the defaults that changed. But you do not need to manually specify it

the defaults match what the 1.x docs are showing

docs/how_to_add_packages.md Outdated Show resolved Hide resolved

Getting started is easy. Try building an existing package with our [developing recipes](../developing_recipes_locally.md) tutorial.
To deepen you understanding, start with the [How to provide a good recipe](#how-to-provide-a-good-recipe) section.
You can follow the three steps (:one: :two: :three:) described below! :tada:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be 1, 2, 3 links to sections in this doc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant idea! sadly this one does not break like that but

prince-chrismc@bb59e8a

🤞 should be able to fix that soon

docs/how_to_add_packages.md Outdated Show resolved Hide resolved
docs/how_to_add_packages.md Outdated Show resolved Hide resolved
Co-authored-by: Uilian Ries <uilianries@gmail.com>
docs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved

### Try it yourself

For instance you can create packages for `fmt` in various supported configurations by running:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt is a good choice.

docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
export PYTHONPATH=your/path/conan-center-index
```

* Now you just need to execute the `pylint` commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to leverage something like pre-commit to make it easy to have the linters run before committing code locally. I'm liable to forget.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too 🙊 one day we will have an easier way than in the PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a new hook which run linter on pre-export.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

We should add the spdx hook too

docs/developing_recipes_locally.md Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
Chris Mc and others added 2 commits October 1, 2022 17:41
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
@prince-chrismc
Copy link
Contributor Author

👋 @ericLemanissier @SpaceIm @toge @Croydon Looking for some reviews pretty please ❤️

@conan-center-bot conan-center-bot added Docs and removed Docs labels Oct 1, 2022
jwillikers
jwillikers previously approved these changes Oct 1, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! I was looking for it, a centralized document, only a small comment related to close issues. Because I used to see people adding it the issue title instead.

CONTRIBUTING.md Outdated Show resolved Hide resolved
export PYTHONPATH=your/path/conan-center-index
```

* Now you just need to execute the `pylint` commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a new hook which run linter on pre-export.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
jwillikers
jwillikers previously approved these changes Oct 3, 2022
@prince-chrismc
Copy link
Contributor Author

Should be good for a last review 🤞

@conan-center-bot conan-center-bot added Docs and removed Docs labels Oct 4, 2022
@conan-center-bot conan-center-bot added Docs and removed Docs labels Oct 4, 2022
uilianries
uilianries previously approved these changes Oct 5, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few tiny typos / grammar nitpicks, but it looks good.

docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/developing_recipes_locally.md Outdated Show resolved Hide resolved
docs/how_to_add_packages.md Outdated Show resolved Hide resolved
docs/how_to_add_packages.md Outdated Show resolved Hide resolved
docs/how_to_add_packages.md Outdated Show resolved Hide resolved
docs/linters.md Outdated Show resolved Hide resolved
docs/linters.md Outdated Show resolved Hide resolved
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
@prince-chrismc
Copy link
Contributor Author

@jwillikers thank you soo much!!!!! it shows we are not native english speakers and/or wrote too much docs ❤️ really appreciate the great review

@conan-center-bot conan-center-bot added Docs and removed Docs labels Oct 5, 2022
@prince-chrismc
Copy link
Contributor Author

Why is this not being merged 🤔

@prince-chrismc prince-chrismc reopened this Oct 6, 2022
@conan-center-bot conan-center-bot added Docs and removed Docs labels Oct 6, 2022
@conan-center-bot conan-center-bot merged commit 3180533 into conan-io:master Oct 6, 2022
System-Arch pushed a commit to System-Arch/conan-center-index that referenced this pull request Oct 7, 2022
* docs: Document working locally + Conan 2.0 commands

I also snuck in some format and link fixes

* Apply suggestions from code review

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update docs/README.md

* Update docs/developing_recipes_locally.md

* Apply suggestions from code review

Co-authored-by: Jordan Williams <jordan@jwillikers.com>

* Update CONTRIBUTING.md

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* merge linters into dev locally

* links and touch ups

* fix links

* Apply suggestions from code review

Co-authored-by: Jordan Williams <jordan@jwillikers.com>

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants