Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catch2] adapt recipe for Conan v2 #13037

Merged
merged 21 commits into from
Sep 23, 2022
Merged

[Catch2] adapt recipe for Conan v2 #13037

merged 21 commits into from
Sep 23, 2022

Conversation

fpelliccioni
Copy link
Contributor

@fpelliccioni fpelliccioni commented Sep 20, 2022

Specify library name and version: catch2/3.1.0


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/catch2/3.x.x/conanfile.py Outdated Show resolved Hide resolved
recipes/catch2/3.x.x/conanfile.py Show resolved Hide resolved
recipes/catch2/3.x.x/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Uilian Ries <uilianries@gmail.com>
fpelliccioni and others added 2 commits September 20, 2022 12:58
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #12888

There a few extra. You need to update the test packages.

  • rename the current one to test_v1_package/
  • make a new one with old name for the new generators

FMT or rapidjson are the best examples I am using

recipes/catch2/3.x.x/conanfile.py Outdated Show resolved Hide resolved
recipes/catch2/3.x.x/conanfile.py Outdated Show resolved Hide resolved
recipes/catch2/3.x.x/conanfile.py Show resolved Hide resolved
fpelliccioni and others added 3 commits September 22, 2022 03:45
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@fpelliccioni fpelliccioni requested review from prince-chrismc and uilianries and removed request for uilianries and prince-chrismc September 22, 2022 06:59
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpelliccioni please, move those cpp files from test_v1_package to test_package. When we fully migrate to Conan v2 and drop Conan v1, test_v1_package could be removed and those files will be missing for test_package.

@uilianries
Copy link
Member

@conan-center-bot

This comment has been minimized.

* move gtest

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Delete test_all.sh

* Use cmake targets

* Do not use settings

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@fpelliccioni
Copy link
Contributor Author

fpelliccioni#2

thanks, merged

@conan-center-bot
Copy link
Collaborator

All green in build 19 (190da8c7d2bf7b4d4df2bc3f81e0cd1698377160):

  • catch2/2.12.4@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py", line 1, in <module>
        from conans import ConanFile, CMake, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • catch2/2.11.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py", line 1, in <module>
        from conans import ConanFile, CMake, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • catch2/2.13.8@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py", line 1, in <module>
        from conans import ConanFile, CMake, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • catch2/2.13.7@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py", line 1, in <module>
        from conans import ConanFile, CMake, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • catch2/2.13.9@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13037/recipes/catch2/2.x.x/conanfile.py", line 1, in <module>
        from conans import ConanFile, CMake, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • catch2/3.0.1@:
    All packages built successfully! (All logs)

  • catch2/3.1.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 361df20 into conan-io:master Sep 23, 2022
kayoub5 pushed a commit to kayoub5/conan-center-index that referenced this pull request Sep 29, 2022
* [Catch2] adapt recipe for Conan v2

* fixes

* fixes

* fixes

* fixes

* fixes 4

* fixes 5

* fixes 6

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/catch2/3.x.x/conanfile.py

* fix patches

* fix

* fix

* remove comments

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* test package changes

* Move test package files (conan-io#2)

* move gtest

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Delete test_all.sh

* Use cmake targets

* Do not use settings

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
System-Arch pushed a commit to System-Arch/conan-center-index that referenced this pull request Oct 7, 2022
* [Catch2] adapt recipe for Conan v2

* fixes

* fixes

* fixes

* fixes

* fixes 4

* fixes 5

* fixes 6

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/catch2/3.x.x/conanfile.py

* fix patches

* fix

* fix

* remove comments

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/catch2/3.x.x/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* test package changes

* Move test package files (#2)

* move gtest

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Delete test_all.sh

* Use cmake targets

* Do not use settings

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants