-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Catch2] adapt recipe for Conan v2 #13037
[Catch2] adapt recipe for Conan v2 #13037
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For #12888
There a few extra. You need to update the test packages.
- rename the current one to
test_v1_package/
- make a new one with old name for the new generators
FMT or rapidjson are the best examples I am using
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fpelliccioni please, move those cpp files from test_v1_package to test_package. When we fully migrate to Conan v2 and drop Conan v1, test_v1_package could be removed and those files will be missing for test_package.
This comment has been minimized.
This comment has been minimized.
* move gtest Signed-off-by: Uilian Ries <uilianries@gmail.com> * Delete test_all.sh * Use cmake targets * Do not use settings Signed-off-by: Uilian Ries <uilianries@gmail.com>
thanks, merged |
All green in build 19 (
|
* [Catch2] adapt recipe for Conan v2 * fixes * fixes * fixes * fixes * fixes 4 * fixes 5 * fixes 6 * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/catch2/3.x.x/conanfile.py * fix patches * fix * fix * remove comments * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * test package changes * Move test package files (conan-io#2) * move gtest Signed-off-by: Uilian Ries <uilianries@gmail.com> * Delete test_all.sh * Use cmake targets * Do not use settings Signed-off-by: Uilian Ries <uilianries@gmail.com> Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
* [Catch2] adapt recipe for Conan v2 * fixes * fixes * fixes * fixes * fixes 4 * fixes 5 * fixes 6 * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/catch2/3.x.x/conanfile.py * fix patches * fix * fix * remove comments * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update recipes/catch2/3.x.x/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * test package changes * Move test package files (#2) * move gtest Signed-off-by: Uilian Ries <uilianries@gmail.com> * Delete test_all.sh * Use cmake targets * Do not use settings Signed-off-by: Uilian Ries <uilianries@gmail.com> Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Specify library name and version: catch2/3.1.0