Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] source subfolder is no longer used #12878

Merged

Conversation

uilianries
Copy link
Member

Remove source_subfolder from new recipe templates. It's no longer used, as layout is preferred.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Updating docs!

jgsogo
jgsogo approved these changes Sep 9, 2022
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries
Copy link
Member Author

There's more docs about this

https://github.com/conan-io/conan-center-index/blob/master/docs/reviewing.md#subfolder-properties

those should be removed?

It should be updated. Removed in case using cmake_layout. Not all PRs are updating CMake flow, only mandatory tools asked by the linter.

prince-chrismc pushed a commit to prince-chrismc/conan-center-index that referenced this pull request Sep 13, 2022
@conan-center-bot conan-center-bot merged commit 6e721f5 into conan-io:master Sep 14, 2022
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 26, 2022
Signed-off-by: Uilian Ries <uilianries@gmail.com>

Signed-off-by: Uilian Ries <uilianries@gmail.com>
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants