-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.7.2 added + macos cross compile support #12333
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying foonathan-memory/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 131ca31foonathan-memory/0.7.0
foonathan-memory/0.7.1
foonathan-memory/0.7.2
|
# quick fix until somebody can reproduce | ||
if hasattr(self, "settings_build") and cross_building(self): | ||
raise ConanInvalidConfiguration("Cross building is not yet supported. Contributions are welcome") | ||
if self.version == '0.7.0' or not (self.settings.os == "Macos" and self.settings.arch != self.settings_build.arch): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean, only version 0.7.0 is broken? Because the message says it's not supported for any version.
@@ -8,3 +11,7 @@ sources: | |||
patches: | |||
"0.7.0": | |||
- patch_file: "patches/0.7.0-0001-fix-virtualAllocFromApp.patch" | |||
"0.7.1": | |||
- patch_file: "patches/fix-macosCrossCompile.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, add patch_description
and patch_type
as recommended here: https://github.com/conan-io/conan-center-index/blob/master/docs/conandata_yml_format.md#patches-fields
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: foonathan-memory/0.7.2
I needed the abililty to cross compile from macos arm <-> x86_64, and since there's also a new version available I included that as well.
I made a patch to the library to support cross compilation on macos. Maybe the code is too specific, if that's the case just let me know.