Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.7.2 added + macos cross compile support #12333

Closed
wants to merge 7 commits into from

Conversation

willadsen
Copy link
Contributor

Specify library name and version: foonathan-memory/0.7.2

I needed the abililty to cross compile from macos arm <-> x86_64, and since there's also a new version available I included that as well.

I made a patch to the library to support cross compilation on macos. Maybe the code is too specific, if that's the case just let me know.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Aug 22, 2022

I detected other pull requests that are modifying foonathan-memory/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Aug 22, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 7 (131ca31245100270caa5ef808d88944cfaaa609c):

  • foonathan-memory/0.7.0@:
    All packages built successfully! (All logs)

  • foonathan-memory/0.7.1@:
    All packages built successfully! (All logs)

  • foonathan-memory/0.7.2@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Hooks produced the following warnings for commit 131ca31
foonathan-memory/0.7.0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoonathan_memory-0.7.0.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoonathan_memory-0.7.0-dbg.so' links to system library 'm' but it is not in cpp_info.system_libs.
foonathan-memory/0.7.1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoonathan_memory-0.7.1.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoonathan_memory-0.7.1-dbg.so' links to system library 'm' but it is not in cpp_info.system_libs.
foonathan-memory/0.7.2
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoonathan_memory-0.7.2.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libfoonathan_memory-0.7.2-dbg.so' links to system library 'm' but it is not in cpp_info.system_libs.

# quick fix until somebody can reproduce
if hasattr(self, "settings_build") and cross_building(self):
raise ConanInvalidConfiguration("Cross building is not yet supported. Contributions are welcome")
if self.version == '0.7.0' or not (self.settings.os == "Macos" and self.settings.arch != self.settings_build.arch):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean, only version 0.7.0 is broken? Because the message says it's not supported for any version.

@@ -8,3 +11,7 @@ sources:
patches:
"0.7.0":
- patch_file: "patches/0.7.0-0001-fix-virtualAllocFromApp.patch"
"0.7.1":
- patch_file: "patches/fix-macosCrossCompile.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conan-center-bot conan-center-bot requested review from danimtb and removed request for jgsogo October 21, 2022 12:00
@ghost ghost mentioned this pull request Nov 18, 2022
4 tasks
@stale
Copy link

stale bot commented Dec 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 30, 2022
@ghost ghost mentioned this pull request Jan 16, 2023
3 tasks
@stale
Copy link

stale bot commented Feb 2, 2023

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants