-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OneDPL: add versions 2021.6.1 & 2021.7.0 #11635
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6fb07f6
to
d89938a
Compare
Fix license path
This comment has been minimized.
This comment has been minimized.
@jhabermas I see both recipes are pretty similar. Why not combine both on same folder (all)? |
@uilianries As the old recipe has not been maintained since creation I thought it may be easier to just create a new one. The OneDPL project has changed in terms of folders/files layout, but it is possible to merge the two if you think that would be better. |
Yes, please, merge them. In the long term it is easier to maintain just one |
@jgsogo How would you suggest dealing with different include file structure and namespaces, i.e. |
There are several options, but I would just go with the most straightforward one: duplicate the test_package/conanfile.py
and the
But any approach will probably be ok. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of linter errors! 🙌
Specify library name and version: OneDPL/2021.7.0
This PR adds two of the latest versions of OneDPL to the recipe, which allow integration of latest OneTBB and fix C++20 compilation errors.