-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbus/1.12.20: Use CMake to build D-Bus to fix cross-compiling #11616
dbus/1.12.20: Use CMake to build D-Bus to fix cross-compiling #11616
Conversation
1e591bb
to
cc6774d
Compare
This comment has been minimized.
This comment has been minimized.
cc6774d
to
f5501e4
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit f5501e4dbus/1.12.20
|
f5501e4
to
f8f8762
Compare
This comment has been minimized.
This comment has been minimized.
f8f8762
to
f7dc247
Compare
This comment has been minimized.
This comment has been minimized.
Currently, Autotools errors out when attempting to cross-compile D-Bus. However, D-Bus can be built with CMake by defining a simple variable. Using CMake, D-Bus is able to be cross-compiled successfully. This minimizes the complexity of the D-Bus Conanfile by using 1 build system. D-Bus has better support for CMake in newer versions. This should lead to reduced maintenance overhead in the future, too.
f7dc247
to
08305de
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ericLemanissier PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question
This reverts commit 49ace14.
This comment has been minimized.
This comment has been minimized.
d936b5c
to
c67f566
Compare
@tsondergaard I figured out the issue when building on FreeBSD using CMake. As it turns out, there's even an existing commit upstream that fixes the issue. I've pulled that commit as a patch here and it now builds for me on FreeBSD using CMake. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All green in build 21 (
|
Currently, Autotools errors out when attempting to cross-compile D-Bus.
However, D-Bus can be built with CMake by defining a simple variable.
Using CMake, D-Bus is able to be cross-compiled successfully.
This minimizes the complexity of the D-Bus Conanfile by using 1 build system.
D-Bus has better support for CMake in newer versions.
This should lead to reduced maintenance overhead in the future, too.
Specify library name and version: dbus/1.12.20