Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modern-cpp-kafka: new recipe #11430

Merged
merged 8 commits into from
Jul 21, 2022

Conversation

kenneth-jia
Copy link
Contributor

Specify library name and version: modern-cpp-kafka/v2022.06.15

Hi,
I'm the author of modern-cpp-kafka (https://github.com/morganstanley/modern-cpp-kafka), a Kafka C++ API, wrapper over librdkafka).
Now I'm trying to add this header-only library to the ConanCenter (morganstanley/modern-cpp-kafka#105)
Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge
Copy link
Contributor

toge commented Jun 29, 2022

@kenneth-jia
Hello.
Thanks for creating the conan recipe!

Unfortunately, the recipe you wrote must have test_package folder.
There is a recently created template as a sample of the recipe, could you please refer this as a reference to modify it?
https://github.com/conan-io/conan-center-index/tree/master/docs/package

@kenneth-jia kenneth-jia force-pushed the RecipeForModernCppKafka branch from e08d25e to e113acd Compare June 30, 2022 09:48
@conan-center-bot

This comment has been minimized.

@kenneth-jia kenneth-jia force-pushed the RecipeForModernCppKafka branch from e113acd to 2104ddd Compare June 30, 2022 09:51
@conan-center-bot

This comment has been minimized.

@kenneth-jia
Copy link
Contributor Author

kenneth-jia commented Jun 30, 2022

@kenneth-jia Hello. Thanks for creating the conan recipe!

Unfortunately, the recipe you wrote must have test_package folder. There is a recently created template as a sample of the recipe, could you please refer this as a reference to modify it? https://github.com/conan-io/conan-center-index/tree/master/docs/package

Just added the test_package part, and now is pending on the access approval. Thanks! @toge

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

recipes/modern-cpp-kafka/all/conandata.yml Outdated Show resolved Hide resolved
recipes/modern-cpp-kafka/all/conanfile.py Outdated Show resolved Hide resolved
recipes/modern-cpp-kafka/all/conanfile.py Show resolved Hide resolved
recipes/modern-cpp-kafka/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/modern-cpp-kafka/config.yml Outdated Show resolved Hide resolved
recipes/modern-cpp-kafka/all/conanfile.py Outdated Show resolved Hide resolved
@kenneth-jia kenneth-jia force-pushed the RecipeForModernCppKafka branch from 2104ddd to eed689c Compare July 1, 2022 05:07
@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@kenneth-jia kenneth-jia requested a review from uilianries July 5, 2022 02:02
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a small detail

recipes/modern-cpp-kafka/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@kenneth-jia kenneth-jia requested a review from uilianries July 5, 2022 07:24
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Jul 5, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just need to wait for user approval.

@kenneth-jia
Copy link
Contributor Author

LGTM

Just need to wait for user approval.

Thank you a lot for the help, @uilianries! 😀

@uilianries
Copy link
Member

@kenneth-jia No, thank you for contributing! 💚

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@kenneth-jia kenneth-jia force-pushed the RecipeForModernCppKafka branch from f02663c to 4fdd7a5 Compare July 20, 2022 01:21
@kenneth-jia kenneth-jia force-pushed the RecipeForModernCppKafka branch 2 times, most recently from 6df4ae8 to ade4972 Compare July 20, 2022 01:33
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

kenneth-jia and others added 2 commits July 20, 2022 22:32
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
@conan-center-bot

This comment has been minimized.

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 27 (acac5710be98e23a6fa34d062abc147dfa7370d1):

  • modern-cpp-kafka/2022.06.15@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11430/recipes/modern-cpp-kafka/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11430/recipes/modern-cpp-kafka/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-11430/recipes/modern-cpp-kafka/all/conanfile.py", line 1, in <module>
        from conans import ConanFile, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@kenneth-jia kenneth-jia requested a review from jgsogo July 20, 2022 15:29
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Let me explain the logic with v2 migration and those test folders:

  • every recipe should have a test_package, it is the default name that Conan will look for.
  • recipes in CCI can have several test_xxxx folders, and the CI here will execute all of them. Why? Sometimes it is useful to write several tests to check the names for different generators.
  • if for some reason, there is a test we want to keep and it can only run with Conan v1 (for example, we want to keep testing cmake_find_package), then the folder should be named test_v1_xxxx, i.e.: https://github.com/conan-io/conan-center-index/tree/master/recipes/fmt/all

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit ac5faf2 into conan-io:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants