Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objectbox: add recipe #11359

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Conversation

toge
Copy link
Contributor

@toge toge commented Jun 24, 2022

Specify library name and version: objectbox/0.17.0

Try to fix #11235.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge
Copy link
Contributor Author

toge commented Jun 24, 2022

ConanException: Error 3221225781 while executing bin\test_package

It may be caused by failing to find objectbox.dll.
I am going to find the solution...

@SSE4
Copy link
Contributor

SSE4 commented Jun 24, 2022

yes, 3221225781 == C0000135 which is STATUS_DLL_NOT_FOUND

@toge
Copy link
Contributor Author

toge commented Jun 24, 2022

@SSE4
Thank you!

@toge toge closed this Jun 26, 2022
@toge toge reopened this Jun 26, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 4 (13b22f77e4a103bba9f49d9708ec32fe4bdbdd18):

  • objectbox/0.17.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 4027432 into conan-io:master Jun 27, 2022
@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 1, 2023

FYI this recipe doesn't follow CCI policies. It silently downloads pre-compiled binaries of objectbox at build time instead of building from source.
Instead this recipe should explicitly specify pre-compiled binaries to download in conandata.yml, so that each download is under control, and not pretend doing a true build from source.
There are probably more issues related to:

  • package id because we don't know which compiler, cppstd, runtime or libcxx were used for each pre-compiled binary. Also macOS binary seems to be universal...
  • dependency graph: what is vendored? It's a black box.

I'm not sure this recipe should have been accepted since it's closed-source.

@prince-chrismc
Copy link
Contributor

The implementation of the database is closed but the API and libs are free to distribute. It's an edge case I added it to the shepherds meetings for the team to discuss. Gut reaction this is fine, it did not raise alram bells when I reviewed.

I think it this is not covered under our current guidelines but hopefully we can clarify that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] objectbox/0.17.0
6 participants