fix bugs in igntion-tools recipe #11309

ggulgulia · 2022-06-21T11:00:11Z

Specify library name and version: ignition-tools/1.4.0*

Description

The current recipe had several issues
- incorrect Findignition-tools1.cmake (:x:) generation instead of Findignition-tools.cmake (:heavy_check_mark: ) generation
- incorrect library component name ignition-tools1 (:x:) instead of ignition-tools (:heavy_check_mark: )
- missing core library component name
- missing various cmake variables for
This PR fixes the issues

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

ggulgulia · 2022-06-21T18:14:03Z

@uilianries in the error, it seems that ruby/3.1.0 and gmp/6.1.2 conan packages are downloaded but then build cannot find binaries. What am I missing here ?

use `CONFIG` : find_package(pkg-name CONFIG)

override default conan behavior specifying `package_folder/include` dir

ggulgulia · 2022-07-23T11:55:30Z

@prince-chrismc can you please review once again ?

github-actions · 2022-07-23T13:59:36Z

Hooks produced the following warnings for commit ae68bd3

ignition-tools/1.4.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libignition-tools-backward.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\lib\ignition-tools-backward.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.

prince-chrismc

Since the goal of the PR is to fix the generators.

I would be nice to have https://github.com/gazebosim/gz-tools/blob/20bcaf96bed27850b256fe3ac95c0aa1640143fe/CMakeLists.txt#L190

prince-chrismc · 2022-07-25T21:20:05Z

recipes/ignition-tools/all/conanfile.py

+        self.cpp_info.names["cmake_find_package"] = lib_name
+        self.cpp_info.names["cmake_find_package_multi"] = lib_name
+        self.cpp_info.set_property("cmake_file_name", "ignition-tools")
+        self.cpp_info.components["backward"].names["cmake_find_package"] = "backward"


I am not sure whats the best option here but the targets are not correctly exporting from the upstream project... Does this match the projects intentions? I am not sure I can answer that...

https://cmake.org/cmake/help/latest/guide/importing-exporting/index.html#exporting-targets calls out install(EXPORT...) and install(TARGETS ...) neither exist 😕

https://github.com/gazebosim/gz-tools/blob/ignition-tools_1.4.0/src/CMakeLists.txt#L29 main gets closer but it's still not doing something consumers would rely on AFAIK.

recipes/ignition-tools/all/conanfile.py

github-actions · 2022-07-26T08:52:19Z

Hooks produced the following warnings for commit 3b54cde

ignition-tools/1.4.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\lib\ignition-tools-backward.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.

conan-center-bot · 2022-07-29T13:46:03Z

All green in build 31 (1ff89f45afad944b449d5447eb95adec40f364b1):

ignition-tools/1.4.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-11309/recipes/ignition-tools/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-11309/recipes/ignition-tools/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-11309/recipes/ignition-tools/all/conanfile.py", line 2, in <module>
    from conans import CMake, ConanFile, tools
ImportError: cannot import name 'CMake' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

github-actions · 2022-07-29T13:46:21Z

Hooks produced the following warnings for commit 1ff89f4

ignition-tools/1.4.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\lib\ignition-tools-backward.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.

ggulgulia · 2022-08-01T08:14:03Z

Since the goal of the PR is to fix the generators.

I would be nice to have https://github.com/gazebosim/gz-tools/blob/20bcaf96bed27850b256fe3ac95c0aa1640143fe/CMakeLists.txt#L190

@prince-chrismc does this mean I should install the package config file ignition-tools.pc ? The content of this file from the library installed version has only 4 lines:

# This packages provides no headers or libraries, so those fields are omitted
Name: Ignition tools
Description: A set of tools classes for robot applications
Version: 1.4.0

So I'm not sure if installing this is really useful. What do you think ?

ggulgulia · 2022-08-05T08:45:51Z

any update on my queries ?

jgsogo · 2022-08-05T09:24:20Z

The whole purpose of Conan is to generate those .pc files (or FindXXX.cmake, XXX-config.cmake) using its own generators, to take into account all the dependencies and so on. Generated .pc file by Conan should contain more accurate information (https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#why-are-cmake-findconfig-files-and-pkg-config-files-not-packaged).

prince-chrismc · 2022-08-08T22:56:42Z

recipes/ignition-tools/all/conandata.yml

-    url: "https://github.com/ignitionrobotics/ign-tools/archive/refs/tags/ignition-tools_1.4.0.tar.gz"
-    sha256: "fa3f7984ebb8f412133ea93368395adce426ae36c715a9f94f9509af7dac3b03"
+    url: "https://github.com/gazebosim/gz-tools/archive/refs/tags/ignition-tools_1.4.0.tar.gz"
+    sha256: "8ceebefcd1977dc2e26beede347a9c06d851b89ec0fd7d5c86126f43a49ac178"


@jcar87 We have another check sum change for you to label 👏

prince-chrismc · 2022-08-08T22:59:15Z

@prince-chrismc does this mean I should install the package config file ignition-tools.pc ? The content of this file from the library installed version has only 4 lines:

You can set the properties

conan-center-index/recipes/wayland/all/conanfile.py

Line 134 in 3fba379

    
           self.cpp_info.components["wayland-server"].set_property("pkg_config_name", "wayland-server")

conan-center-index/recipes/wayland/all/conanfile.py

Line 141 in 3fba379

    
           self.cpp_info.components["wayland-server"].set_property("component_version", self.version)

stale · 2022-09-30T18:18:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2022-11-22T18:17:02Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

fix: bugs in igntion-tools recipe

755c364

ggulgulia mentioned this pull request Jun 21, 2022

package/ignition-msg5x/8.x conan recipe #9671

Closed

4 tasks

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 21, 2022

use correct ruby from CCI

8d0da44

conan-center-bot removed the Failed label Jun 21, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 21, 2022

fix: hook errors, remove include paths in package info

5d4bfef

conan-center-bot removed the Failed label Jun 21, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 21, 2022

Update conanfile.py

746d389

conan-center-bot removed the Failed label Jun 21, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 21, 2022

test with find_package_multi

a2b8f6b

conan-center-bot removed the Failed label Jun 21, 2022

test with find_package_multi

492fff5

use `CONFIG` : find_package(pkg-name CONFIG)

github-actions bot mentioned this pull request Jun 21, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 21, 2022

ggulgulia closed this Jun 24, 2022

ggulgulia reopened this Jun 24, 2022

conan-center-bot removed the Failed label Jun 24, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 24, 2022

fix: specify empty include dir

6b5a21a

override default conan behavior specifying `package_folder/include` dir

conan-center-bot removed the Failed label Jun 24, 2022

chore: clean package method in recipe

ae68bd3

This comment has been minimized.

Sign in to view

uilianries previously approved these changes Jul 25, 2022

View reviewed changes

prince-chrismc reviewed Jul 25, 2022

View reviewed changes

recipes/ignition-tools/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Jul 25, 2022

View reviewed changes

recipes/ignition-tools/all/conanfile.py Outdated Show resolved Hide resolved

chore: apply reivew comments

dfd79a3

ggulgulia dismissed uilianries’s stale review via dfd79a3 July 26, 2022 07:49

fix: package_info remove cmake_paths

3b54cde

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jul 26, 2022

remove extra test package

1ff89f4

conan-center-bot removed the Failed label Jul 29, 2022

prince-chrismc reviewed Aug 8, 2022

View reviewed changes

conan-center-bot requested review from uilianries and jcar87 August 25, 2022 12:03

stale bot added the stale label Sep 30, 2022

SSE4 approved these changes Oct 15, 2022

View reviewed changes

stale bot closed this Nov 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix bugs in igntion-tools recipe #11309

fix bugs in igntion-tools recipe #11309

ggulgulia commented Jun 21, 2022 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ggulgulia commented Jun 21, 2022

This comment has been minimized.

This comment has been minimized.

ggulgulia commented Jul 23, 2022

This comment has been minimized.

github-actions bot commented Jul 23, 2022

prince-chrismc left a comment

prince-chrismc Jul 25, 2022 •

edited

Loading

This comment has been minimized.

github-actions bot commented Jul 26, 2022

conan-center-bot commented Jul 29, 2022

github-actions bot commented Jul 29, 2022

ggulgulia commented Aug 1, 2022

ggulgulia commented Aug 5, 2022

jgsogo commented Aug 5, 2022

prince-chrismc Aug 8, 2022

prince-chrismc commented Aug 8, 2022

stale bot commented Sep 30, 2022

stale bot commented Nov 22, 2022

fix bugs in igntion-tools recipe #11309

fix bugs in igntion-tools recipe #11309

Conversation

ggulgulia commented Jun 21, 2022 • edited Loading

Description

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ggulgulia commented Jun 21, 2022

This comment has been minimized.

This comment has been minimized.

ggulgulia commented Jul 23, 2022

This comment has been minimized.

github-actions bot commented Jul 23, 2022

prince-chrismc left a comment

Choose a reason for hiding this comment

prince-chrismc Jul 25, 2022 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Jul 26, 2022

conan-center-bot commented Jul 29, 2022

github-actions bot commented Jul 29, 2022

ggulgulia commented Aug 1, 2022

ggulgulia commented Aug 5, 2022

jgsogo commented Aug 5, 2022

prince-chrismc Aug 8, 2022

Choose a reason for hiding this comment

prince-chrismc commented Aug 8, 2022

stale bot commented Sep 30, 2022

stale bot commented Nov 22, 2022

ggulgulia commented Jun 21, 2022 •

edited

Loading

prince-chrismc Jul 25, 2022 •

edited

Loading