Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignition-utils #11174

Merged
merged 4 commits into from
Jun 17, 2022
Merged

fix: ignition-utils #11174

merged 4 commits into from
Jun 17, 2022

Conversation

ggulgulia
Copy link
Contributor

@ggulgulia ggulgulia commented Jun 14, 2022 •
edited
Loading

Library Details

Description

  • The current recipe of ignition-math has bugs

Fix summary

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ggulgulia
Copy link
Contributor Author

@SSE4 what went wrong in the continuous-integration/jenkins/pr-merge pipeline ?

@uilianries
Copy link
Member

@ggulgulia It seems like github didn't the notification, because it passed on CI.

@conan-center-bot
Copy link
Collaborator

All green in build 6 (a069a1ef81fe2c4ad081be49fadf748c96754553):

  • ignition-utils/1.3.0@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 9a2ab3c into conan-io:master Jun 17, 2022
hoxnox pushed a commit to hoxnox/conan-center-index that referenced this pull request Jun 30, 2022
@ggulgulia @hoxnox
(conan-io#11174) fix: ignition-utils
d9821ef 
* fix: recipe components and cmake VERSION variables

* fix: update the sha256

* fix: build, import textwrap

* fix: build, specify builddirs correctly for components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggulgulia @conan-center-bot @uilianries @SSE4