Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdf5] Bump dependencies and add missing versions #10179

Closed
wants to merge 2 commits into from

Conversation

tbeu
Copy link
Contributor

@tbeu tbeu commented Apr 8, 2022

Specify library name and version: hdf5/1.12.1


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@tbeu tbeu changed the title [hdf5] Bump dependencies [hdf5] Bump dependencies and add missing versions Apr 10, 2022
@conan-center-bot conan-center-bot removed the Bump dependencies Only bumping dependencies versions in the recipe label Apr 10, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@tbeu
Copy link
Contributor Author

tbeu commented Apr 14, 2022

@SpaceIm Why is it failing? Shall 1.10.5, 1.10.6 and 1.10.7 be removed?

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@tbeu Do you need those old versions? Otherwise, I suggest avoid them.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Apr 29, 2022

@jgsogo

hdf5 recipe raises if cross-built:

if hasattr(self, "settings_build") and tools.cross_building(self, skip_x64_x86=True):
# While building it runs some executables like H5detect
raise ConanInvalidConfiguration("Current recipe doesn't support cross-building (yet)")

It has not been changed in this PR, but yet CI tries to cross-build to macOS M1 (and fails): https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/10179/8-configs/macos-m1-clang/hdf5/1.12.1//summary.json

@jgsogo
Copy link
Contributor

jgsogo commented Apr 29, 2022

Triggering again after removing the cached packageIDs.... let's what happens now. Now it should compute INVALID_PACKAGE

@ghost
Copy link

ghost commented Apr 29, 2022

I detected other pull requests that are modifying hdf5/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Failure in build 11 (201b713268ee0b958dfc0f49f76a5940f7b66573):

  • hdf5/1.10.5@:
    Didn't run or was cancelled before finishing

  • hdf5/1.12.1@:
    Didn't run or was cancelled before finishing

  • hdf5/1.10.8@:
    An unexpected error happened and has been reported

  • hdf5/1.10.6@:
    Didn't run or was cancelled before finishing

  • hdf5/1.8.22@:
    Didn't run or was cancelled before finishing

  • hdf5/1.10.7@:
    Didn't run or was cancelled before finishing

  • hdf5/1.8.21@:
    Didn't run or was cancelled before finishing

  • hdf5/1.12.0@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@SSE4
Copy link
Contributor

SSE4 commented May 27, 2022

there are conflicts, please rebase

@paulharris
Copy link
Contributor

I'm working on another HDF5 PR,
I see this PR introduces a lot of older HDF5 versions, and bumps some deps (which have since been bumped separately).

Is there a reason to support these older HDF5 versions?
If not then I humbly suggest that this PR can be closed.

@ghost ghost mentioned this pull request Jul 3, 2022
4 tasks
@jgsogo
Copy link
Contributor

jgsogo commented Jul 8, 2022

Unless someone request it explicitly, there is no interest on our side in adding older versions. In fact, according to CCI policies only the latest versions should be available (of course, this is enforcer more strictly for bigger libraries that takes too much time to build)

@tbeu
Copy link
Contributor Author

tbeu commented Jul 10, 2022

OK.

@tbeu tbeu closed this Jul 10, 2022
@tbeu tbeu deleted the bump-hdf5-deps branch July 10, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants