Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[package] libpq/13.2: needless option "with_zlib" #5055

Closed
sabelka opened this issue Mar 26, 2021 · 3 comments · Fixed by #5060
Closed

[package] libpq/13.2: needless option "with_zlib" #5055

sabelka opened this issue Mar 26, 2021 · 3 comments · Fixed by #5060
Labels
bug Something isn't working

Comments

@sabelka
Copy link
Contributor

sabelka commented Mar 26, 2021

The recipe for libpq contains the option with_zlib, which is then passed as --with-zlib to the configure script of PostgreSQL.

However, zlib is not used at all in libpq (it is used in only in other parts of PostgreSQL, e.g. pg_dump).
libpq can be built completely without zlib, without any loss in functionality.

Therefore, the option with_zlib in the recipe for libpq is redundant. Enabling it, just adds an unnecessary dependency on zlib.
It can be completely removed, and --without-zlib always passed to the configure script of PostgreSQL.
@sabelka sabelka added the bug Something isn't working label Mar 26, 2021
@SSE4
Copy link
Contributor

SSE4 commented Mar 26, 2021

related: #5020

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 26, 2021

@sabelka could you submit a PR with these modifications?

@sabelka
Copy link
Contributor Author

sabelka commented Mar 26, 2021

I'll try ;-)

sabelka added a commit to sabelka/conan-center-index that referenced this issue Mar 26, 2021
@sabelka
libpq: deprecate useless option "with_zlib"
c317d98 
zlib is not used anywhere insinde libpq, thus it is just an unnecessary
dependency.

fixes conan-io#5055
@sabelka sabelka mentioned this issue Mar 26, 2021
Merged
4 tasks
conan-center-bot pushed a commit that referenced this issue Jul 11, 2021
@sabelka
(#5060) libpq: deprecate useless option "with_zlib"
4c64c55 
* libpq: deprecate useless option "with_zlib"

zlib is not used anywhere insinde libpq, thus it is just an unnecessary
dependency.

fixes #5055

* remove with_zlib option

Im response to review by madebr: By removing the with_zlib option, libpq packages configured with different option values, will be aliased to the same package id. Which is correct as they are the same.

* manage fPIC
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this issue Jul 19, 2021
@sabelka @AndreyMlashkin
(conan-io#5060) libpq: deprecate useless option "with_zlib"
224aa5a 
* libpq: deprecate useless option "with_zlib"

zlib is not used anywhere insinde libpq, thus it is just an unnecessary
dependency.

fixes conan-io#5055

* remove with_zlib option

Im response to review by madebr: By removing the with_zlib option, libpq packages configured with different option values, will be aliased to the same package id. Which is correct as they are the same.

* manage fPIC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libpq: deprecate useless option "with_zlib" sabelka/conan-center-index
3 participants
@SSE4 @SpaceIm @sabelka