Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Uilian Ries <uilianries@gmail.com>
  • Loading branch information
paulharris and uilianries authored Oct 28, 2022
1 parent 153b39d commit dc7f6e3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion recipes/cli11/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def package(self):
rmdir(self, os.path.join(self.package_folder, "share"))

def package_id(self):
self.info.clear() # header only
self.info.clear()

def package_info(self):
self.cpp_info.set_property("cmake_file_name", "CLI11")
Expand Down
3 changes: 1 addition & 2 deletions recipes/cli11/all/test_package/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.8)
project(test_package CXX)

find_package(CLI11 REQUIRED CONFIG)

add_executable(${CMAKE_PROJECT_NAME} test_package.cpp)
target_link_libraries(${CMAKE_PROJECT_NAME} PRIVATE CLI11::CLI11)

# Note: this could be C++11 or later
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_11)
1 change: 0 additions & 1 deletion recipes/cli11/all/test_package/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import os


# It will become the standard on Conan 2.x
class TestPackageConan(ConanFile):
settings = "os", "arch", "compiler", "build_type"
generators = "CMakeDeps", "CMakeToolchain", "VirtualRunEnv"
Expand Down

0 comments on commit dc7f6e3

Please sign in to comment.