Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Uilian Ries <uilianries@gmail.com>
  • Loading branch information
dvirtz and uilianries authored Nov 10, 2022
1 parent 0df272d commit 0ab6ad4
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions recipes/polymorphic_value/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,22 @@ def _minimum_compilers_version(self):
}

def validate(self):
if self.info.settings.get_safe("compiler.cppstd"):
if self.settings.get_safe("compiler.cppstd"):
check_min_cppstd(self, self._minimum_cpp_standard)
min_version = self._minimum_compilers_version.get(
str(self.info.settings.compiler))
str(self.settings.compiler))
if not min_version:
self.output.warning("{} recipe lacks information about the {} "
"compiler support.".format(
self.name, self.info.settings.compiler))
self.name, self.settings.compiler))
else:
if Version(self.info.settings.compiler.version) < min_version:
if Version(self.settings.compiler.version) < min_version:
raise ConanInvalidConfiguration(
"{} requires C++{} support. "
"The current compiler {} {} does not support it.".format(
self.name, self._minimum_cpp_standard,
self.info.settings.compiler,
self.info.settings.compiler.version))
self.settings.compiler,
self.settings.compiler.version))

def package_id(self):
self.info.clear()
Expand Down

0 comments on commit 0ab6ad4

Please sign in to comment.