Fix/238 #241
Closed
Fix/238 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Sep 1, 2020
| @@ -586,25 +586,24 @@ macro(conan_config_install) | |||
| endif() | |||
|
|
|||
| if(DEFINED CONAN_VERIFY_SSL) | |||
| set(CONAN_CONFIG_INSTALL_ARGS "${CONAN_CONFIG_INSTALL_ARGS} --verify-ssl ${CONAN_VERIFY_SSL}") | |||
| string(STRIP "${CONAN_CONFIG_INSTALL_ARGS} --verify-ssl=${CONAN_VERIFY_SSL}" CONAN_CONFIG_INSTALL_ARGS) | |||
There was a problem hiding this comment.
This way of concatenating args, using a STRIP is a bit weird. I think I would have concat (using "=", that is correct), and then strip at the end if necessary. Am I missing something?
There was a problem hiding this comment.
Yes, it's a bit weird, in fact, I have just realized that there was another PR from an user solving this: #215 I'll close this one in favor of that one and add the test there.
|
Closing in favor of #215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #238