CPS-472: Add My Activities Feed dashlet #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deb1990
approved these changes
Mar 31, 2021
|
Guys, this clearly doesn't fit in a dashlet and there is already a my activities dashlet so I'm not sure why we've gone down this route? |
|
Agreed @jamienovick . Can you please coordinate with @james-compucorp to get the right specs for this one? The good news is that the dashlet can support Angular so we have a bit more flexibility in what we can provide. |
|
Closing until we agree on a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR reintroduces the My Activities dashboard tab, but as a dashlet instead.
The My Activities tab was removed in #717
How it looks
Technical Details
We created a new directive that has all the filters needed for the activity feed to display the incomplete activities belonging to the logged in user. This directive is used as the dashlet on the dashboard.
The
skipUrlParamatersBindingparameter was added to the activity feed directive because the dashboard doesn't have the angular router enabled and binding URL parameters break. This only blocks the filters from being stored in the URL in case they refreshe it.