CPS-356: Fix issue with End/Start date not updating on Peoples tab #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5562c8 to
caa75de
Compare
b91fd3c to
02d6910
Compare
02d6910 to
62e674e
Compare
reneolivo
requested changes
Mar 1, 2021
| @@ -22,7 +22,7 @@ | |||
| "--no-sandbox" | |||
| ] | |||
| }, | |||
| "asyncCaptureLimit": 3, | |||
| "asyncCaptureLimit": 1, | |||
There was a problem hiding this comment.
Using more than 1 thread creates lot of false negatives. But with 1, its much more reliable.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const Utility = require('./utility.js'); | |||
|
|
|||
| module.exports = async (page, scenario, viewport) => { | |||
| module.exports = async (page, scenario, viewport, dontWait) => { | |||
There was a problem hiding this comment.
too many parameters. Let's use options if possible. And instead of don't wait why not a { wait: 0 } with the default being 1000 ?
| } | ||
|
|
||
| await mouseEventsHelper(page, scenario); | ||
| await mouseEventsHelper(page, scenario, null, true); |
There was a problem hiding this comment.
null, and true are not very clear. This is the problem of sending a lot of parameters, specially boolean parameters.
| // remove drupal/civicrm error logging, which creates difference | ||
| await this.removeElements('#console'); | ||
|
|
||
| await this.closeSystemErrorNotification(); |
There was a problem hiding this comment.
why not remove the notifications instead of closing them and waiting for them to close?
f260db3 to
1f434ec
Compare
reneolivo
approved these changes
Mar 2, 2021
This was referenced Mar 5, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the peoples tab of Case Details, after updating the Start/End date from the inline datepicker, the dates got reverted when going to another tab, and then coming back to Peoples tab. This PR fixes this bug.
Before
After
Technical Details
Every time we go to Peoples tab, it fetches the Roles from
$scope.item. But once we update a relationship, if we don't callrefreshfunction, the$scope.itemwont be changed. So again it will revert back to previous values, when going back to the tab.But calling
$scope.refreshupdates the$scope.itemobject, which trickles down to individual tabs like People Tab.For all other fields of the people tab,
$scope.refreshwas called, but it was not for while updating the dates, hence the bug happened.To fix this,
ang/civicase-base/directives/send-to-api-on-change.directive.jshas been removed as its not used anymore.Also replaced
data-api-data="roleDatesUpdater.getApiCallsForStartDate(role, item.id)"withng-change="refresh(roleDatesUpdater.getApiCallsForStartDate(role, item.id))".Backstop JS
Similar to compucorp/backstopjs-config#45, the ability to run backstop on customisable branches has been added. The following inputs are taken from the user to run the tests
Also all the backstop scenarios has been fixed, and in my last few testing, there was 0 false positives.
Also removed loading state scenarios as they were not working 90% of the time.