CIVIMM-212: Support Credit card contribution #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra line item parameters required to compute the appropriate line item amounts are not passed to the pre-hook for credit card contributions. In this PR we now retrieve the necessary values from the form submitted value.
shahrukh-compuco
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Preventing creating incomplete credit card contributions with incorrect tax and total value
Before
before.mp4
After
Technical Details
The extra line item parameters required to compute the appropriate line item amounts are not passed to the pre-hook for credit card contributions.
In this PR we now retrieve the necessary values from the form submitted valu.