CIVIPLMMSR-383: Respect Default Payment Method On Contribution Pages #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we discuss this ticket also as I think I understood it differently? |
olayiwola-compucorp
approved these changes
Jan 23, 2025
a8570c1 to
15e8300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In this pr we fixed the account receivable payment method for contributions that will be created as pending but same pr also created a bug in which account receivable was getting selected for completed contributions as well even though the default payment method was selected as something else. This pr fixes this issue and now for contributions that tends to record payment have default payment method as selected by default on page load where as for pending contributions the account receivable is selected by default.
Before
After