Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIVIPLMMI-189: Align Hook With Upgrader Code #201

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

shahrukh-compuco
Copy link
Contributor

Overview

here we added a hook and an upgrader to update the line item's price field and price field value ids, this pr makes the code more consistent between upgrader and hook.

@olayiwola-compucorp
Copy link
Contributor

Hi @shahrukh-compuco could you do the check ($this->objectName !== 'LineItem' || !in_array($this->op, ['create', 'edit']) even before constructing the hook object.

@shahrukh-compuco shahrukh-compuco force-pushed the civiplmmi-189-add-contribution-clause branch from 9fa4874 to e3498ba Compare October 4, 2024 09:27
@shahrukh-compuco
Copy link
Contributor Author

Hi @shahrukh-compuco could you do the check ($this->objectName !== 'LineItem' || !in_array($this->op, ['create', 'edit']) even before constructing the hook object.

changed

@shahrukh-compuco shahrukh-compuco merged commit 25625ac into master Oct 4, 2024
2 checks passed
@shahrukh-compuco shahrukh-compuco deleted the civiplmmi-189-add-contribution-clause branch October 4, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants