Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATL-1446: Contact Card's email addresses link #35

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

reneolivo
Copy link
Member

Overview

This PR applies the changes introduced by dev/core#1790 to our CiviCRM version.

The changes are related to allowing users to click on email addresses on Contact's cards and send emails to these addresses using the email activity form. For more information please visit the original PR:

civicrm#17517

@reneolivo reneolivo force-pushed the CATL-1446-contact-card-email-links branch from 96bd1b0 to 73029b8 Compare June 17, 2020 19:29
@reneolivo
Copy link
Member Author

@tunbola fixed the tests. The issue happened because this class is used to display data on an email that arrives after a contribution payment. The tests were failing because they were expecting strings like Email Address: anthony_anderson@civicrm.org, but they were getting Email Address: <a href="...">anthony_anderson@civicrm.org</a>, which is the change we made.

This means that plain text emails are getting HTML markup, as it can be seen in one of the failing tests:

Screen Shot 2020-06-17 at 7 31 54 PM
https://test.civicrm.org/job/CiviCRM-Core-PR/34755/testReport/junit/(root)/CRM_Core_Payment_AuthorizeNetIPNTest/testIPNPaymentMembershipRecurSuccessNoLeakage/

But as seen from the same text, this has already been happening for parts not related to our PR:
Screen Shot 2020-06-17 at 7 33 10 PM

The HTML part looks OK, except for the URL, which is an issue with the plain text as well:
Screen Shot 2020-06-17 at 7 33 57 PM

The problem with the URL is that it's relative, so we updated the PR so the URL for sending the email is absolute.

Also, to fix the tests we separated the checks so it searches for Email Address: and anthony_anderson@civicrm.org instead of Email Address: anthony_anderson@civicrm.org

@reneolivo reneolivo force-pushed the CATL-1446-contact-card-email-links branch from 4a37723 to 6fdef18 Compare June 18, 2020 12:00
@reneolivo reneolivo merged commit d72bc69 into 5.24.6-patches Jun 18, 2020
@reneolivo reneolivo deleted the CATL-1446-contact-card-email-links branch June 18, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants