Email users on account security changes #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Mar 6, 2024
Seldaek
reviewed
Mar 6, 2024
| @@ -42,6 +43,8 @@ public function changePasswordAction(Request $request, UserPasswordHasherInterfa | |||
| $this->getEM()->persist($user); | |||
| $this->getEM()->flush(); | |||
|
|
|||
| $userNotifier->notifyChange($user->getEmail(), 'Your password has been changed'); | |||
There was a problem hiding this comment.
It would be nice to reuse this UserNotifier for the 2fa emails too I think, to keep it all the same, if you don't mind refactoring that. It probably needs the ability to pass in a custom email template filename tho as the 2fa emails contain some extra wording.
There was a problem hiding this comment.
I don't see this done but no worries I'll do it after merging :)
There was a problem hiding this comment.
Woops I havent add the file sorry x)
I can made a PR fixing that later if you want :)
There was a problem hiding this comment.
Ah no no worries I kinda have it sorted already :)
Seldaek
reviewed
Mar 6, 2024
Seldaek
reviewed
Mar 6, 2024
cd482b9 to
5ca58b3
Compare
4c47443 to
33870f0
Compare
33870f0 to
476854a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1419
Notifying:
Move the two-factor authentication notifier in an dedicated class