SecurityAdvisories: changing the remote ID for the same remote adviso…

…ry should update the source remote ID (#1449)
composer · May 17, 2024 · 61a032c · 61a032c
1 parent 9ae85d8
commit 61a032c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Entity/SecurityAdvisorySource.php b/src/Entity/SecurityAdvisorySource.php
@@ -62,6 +62,7 @@ public function getSeverity(): ?Severity
 
     public function update(RemoteSecurityAdvisory $advisory): void
     {
+        $this->remoteId = $advisory->id;
         $this->severity = $advisory->severity;
     }
 }
diff --git a/tests/SecurityAdvisory/SecurityAdvisoryResolverTest.php b/tests/SecurityAdvisory/SecurityAdvisoryResolverTest.php
@@ -98,6 +98,18 @@ public function testResolveAddSourceToMatchingAdvisory(): void
         $this->assertNotNull($advisory->getSourceRemoteId('other'));
     }
 
+    public function testResolveRemoteIdChangedSameCve(): void
+    {
+        $remoteAdvisory = $this->createRemoteAdvisory('test', cve: 'CVE-2024-9999999999');
+        $advisory = new SecurityAdvisory($this->createRemoteAdvisory('test', cve: 'CVE-2024-9999999999'), 'test');
+        [$new, $removed] = $this->resolver->resolve([$advisory], new RemoteSecurityAdvisoryCollection([$remoteAdvisory]), 'test');
+
+        $this->assertSame([], $new);
+        $this->assertSame([], $removed);
+
+        $this->assertSame($remoteAdvisory->id, $advisory->getSourceRemoteId('test'));
+    }
+
     public function testResolveEmpty(): void
     {
         [$new, $removed] = $this->resolver->resolve([], new RemoteSecurityAdvisoryCollection([]), 'test');